Review main Merged

84108[BUGFIX] Cast to proper string type when performing str_contains

Oliver Hader CR +2 V +2 Easy +19 −5 updated 05/02/24, 13:17

Commit message

When using integer types when calling the fallowing method like
`ImageProcessingInstructions::fromCropScaleValues(.., .., '500m', 0)`,
a PHP type error for `str_contains` is issued.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Oliver Hader uploaded patch set 1 05/02/24, 12:49

  2. core-ci voted on patch set 1 V -1 05/02/24, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57093

  3. Benjamin Franzke uploaded patch set 2 V -1 05/02/24, 13:07

  4. Andreas Kienast voted on patch set 2 CR +1 V +1 05/02/24, 13:12

  5. core-ci voted on patch set 2 V +1 05/02/24, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57095

  6. Benjamin Franzke voted on patch set 2 CR +2 V +2 05/02/24, 13:17

  7. Benjamin Franzke merged patch set 3 05/02/24, 13:17