Review main Merged

84132[FEATURE] Provide language selection in info module

Georg Ringer CR +2 V +2 Normal +172 −22 updated 03/02/25, 18:52

Commit message

The "Web > Info > Pagetree Overview" backend module
now supports filtering by language, allowing to focus
on specific localizations in conjunction with the other
filters.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 2537

Show 912 earlier messages
  1. Georg Ringer uploaded patch set 1 05/02/24, 17:31

  2. core-ci voted on patch set 1 V -1 05/02/24, 17:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57105

  3. Georg Ringer uploaded patch set 2 V -1 05/02/24, 17:39

  4. core-ci voted on patch set 2 V +1 05/02/24, 17:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57106

  5. Georg Ringer uploaded patch set 3 V +1 05/02/24, 18:09

  6. Georg Ringer commented on patch set 3 05/02/24, 18:09

    This change is ready for review.
  7. core-ci voted on patch set 3 V +1 05/02/24, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57112

  8. Guido Schmechel commented on patch set 3 05/04/24, 17:46

    Basically, the feature works with translated pages :-) Edge case: I have the language EN and DK. With non-translated DK pages, but DK language selection set, I end up with the default language (EN) in the page properties instead of creating the DK language version. Is this behaviour okay?
  9. Stefan Bürk commented on patch set 3 CR -1 05/11/24, 18:17

    This seems not to work. Even if a language is selected, and having pages translated into that language, the result set still displays the default language page records and edit/view links are still for default language. Thus, the added dropdown and handling has literally no impact. Having a language selected and not getting the stuff makes literally no sense. @georg.ringer@gmail.com will you have a look again ?
  10. Georg Ringer commented on patch set 3 06/17/24, 20:10

    did you clear the system cache, the change in modules.php requires that
  11. Jasmina Ließmann commented on patch set 3 06/20/24, 12:33

    When testing, I noticed that when a language is selected (in the dropdown menu), the display of the default language when there is no translation irritates me. Assuming I have only translated two pages and in addition to the two pages, 10 more pages are displayed with the default language, it is not so clear to only see the values ​​relevant to the translation. Suggestion: In this case, could you filter the displayed page tree and only show the pages that have actually been translated? (No idea whether the display would work if, for example, a parent page is not translated)

    Reply

    Works for me. Haven't noticed any problems.
  12. Georg Ringer uploaded patch set 4 CR -1 V +1 06/20/24, 19:37

  1. core-ci voted on patch set 4 V +1 06/20/24, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59944

  2. Sebastian Klein commented on patch set 4 08/01/24, 21:20

    Reply

    Tested with Patchset 4: I translated a root page and some subpages. If I select the translation in the Info module and the root page, I see content of the default language. If I select "Depth: 1 level" (or more), the selected root page still shows content in the default language, but the translated subpages will correctly show the localized content. Edit buttons will open the translations for subpages and default language for root page. If I select a translated subpage, I only see content in the default language again. tl;dr: the translation overlay is only applied to subpages of the currently selected page.
  3. Georg Ringer uploaded patch set 5 V +1 08/04/24, 08:32

  4. core-ci voted on patch set 5 V +1 08/04/24, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62823

  5. Sebastian Klein commented on patch set 5 08/05/24, 18:04

    Reply

    With Patchset 5, translated values are rendered correctly, independent of depth settings. Behavior of edit buttons in this module if a translation was selected: - If a single page is listed ("Depth: this page" or a page with no child pages), the edit buttons will open the record of the **default** language. - If multiple pages are listed, all edit buttons on top (as well as in the individual rows) will open the **translated** language. Please note that the rows' edit buttons always have the title "Edit default language page properties", regardless of the selected language. The same translation behavior also applies to the "View webpage" buttons. Additionally, opening a translated page in a listing of multiple pages will use the localized slug, but omits the configured entry point of the Site Configuration (e.g. "/de/").
  6. Jasmina Ließmann uploaded patch set 6 V +1 01/13/25, 19:18

  7. core-ci voted on patch set 6 V -1 01/13/25, 19:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72377

  8. Jasmina Ließmann uploaded patch set 7 V -1 01/13/25, 21:22

  9. core-ci voted on patch set 7 V -1 01/13/25, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72378

  10. Jasmina Ließmann uploaded patch set 8 V -1 01/15/25, 13:17

  11. core-ci voted on patch set 8 V -1 01/15/25, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72520

  12. Jasmina Ließmann uploaded patch set 9 V -1 01/15/25, 14:12

  13. core-ci voted on patch set 9 V -1 01/15/25, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72527

  14. Jasmina Ließmann uploaded patch set 10 V -1 01/15/25, 14:36

  15. core-ci voted on patch set 10 V +1 01/15/25, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72530

  16. Jasmina Ließmann commented on patch set 10 01/15/25, 14:50

    Reply

    I updated the patch and tried to fix the existing errors. Could you please test again with the current patch set?

    Reply

    Has been implemented/resolved in the meantime.
  17. Garvin Hicking uploaded patch set 11 V +1 01/17/25, 11:08

    Adjust RST and commit message
  18. Garvin Hicking commented on patch set 11 V +1 01/17/25, 11:09

    Reply Unresolved

    Works for me! @stefan@buerk.tech - it only worked after I flushed the caches when applying the patch, and I had the same problem before. Could you re-check?
  19. core-ci voted on patch set 11 V +1 01/17/25, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72614

  20. Benni Mack voted on patch set 11 CR +1 V +1 01/21/25, 12:22

  21. Georg Ringer uploaded patch set 12 CR +1 V +1 03/02/25, 15:03

  22. core-ci voted on patch set 12 V +1 03/02/25, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74974

  23. Garvin Hicking voted on patch set 12 CR +1 V +1 03/02/25, 16:46

  24. Georg Ringer voted on patch set 12 CR +2 V +2 03/02/25, 18:52

  25. Georg Ringer merged patch set 13 03/02/25, 18:52