84141[TASK] Deprecate `MathUtility::convertToPositiveInteger()`
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Oliver Klee +1
- Torben Hansen +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oliver Klee +1
- Torben Hansen +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php3+2 −2
- typo3/sysext/core/Classes/Utility/MathUtility.php2+5 −0
- typo3/sysext/core/Documentation/Changelog/13.2/Deprecation-103785-DeprecateMathUtilityConvertToPositiveInteger.rstnew+45 −0
- typo3/sysext/core/Tests/Unit/Utility/MathUtilityTest.php+0 −12
- typo3/sysext/core/Tests/UnitDeprecated/Utility/MathUtilityTest.phpnew+37 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
Review log 1416
-
Andreas Kienast uploaded patch set 1 05/03/24, 07:26
-
Andreas Kienast uploaded patch set 2 05/03/24, 07:26
-
Benjamin Franzke commented on patch set 1 CR -1 05/03/24, 07:27
-
Benjamin Franzke commented on patch set 2 05/03/24, 07:28
MathUtility.php:59ReplyDone -
core-ci voted on patch set 2 V +1 05/03/24, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57160
-
Oliver Klee voted on patch set 2 CR +1 V +1 05/03/24, 07:36
-
Benjamin Franzke commented on patch set 2 05/03/24, 07:43
EditDocumentController.php:914I'm not sure whether viewId is always an int (read from the form data result compiler). Better force-cast `$pageId` to `(int)` until we have defined types. -
Andreas Kienast commented on patch set 2 05/03/24, 07:48
EditDocumentController.php:914ReplyIt's not necessary, `this->popViewId` and `$this->viewId` are cast to int on write. -
Andreas Kienast commented on patch set 2 CR -1 05/03/24, 07:49
EditDocumentController.php:914ReplyNever mind, this->viewId actually isn't. Will add the int cast. -
Andreas Kienast uploaded patch set 3
CR +1V +105/03/24, 07:52 -
core-ci voted on patch set 3 V +1 05/03/24, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57161
-
Oliver Klee voted on patch set 3 CR +1 V +1 05/03/24, 08:13
-
Torben Hansen voted on patch set 3 CR +1 V +1 05/03/24, 09:29
-
Benjamin Franzke voted on patch set 3 CR +1 05/03/24, 09:31
-
Andreas Kienast voted on patch set 3 CR +2 V +2 05/03/24, 09:31
-
Andreas Kienast merged patch set 4 05/03/24, 09:31
MathUtility.php:59