Review main Merged

84143[FEATURE] Add close button to page layout

Sybille Peters CR +2 V +2 Normal +106 −3 updated 09/14/24, 10:23

Commit message

The page layout module now displays a close button if the
query parameters contain returnUrl.

This can be used by extension authors, for example in
combination with the Fluid backend:moduleLink ViewHelper.

The patch also introduces this feature into widgets provided
by sysext:sys-note as an example.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2234

Show 59 earlier messages
  1. Sybille Peters uploaded patch set 1 05/04/24, 07:39

  2. Sybille Peters uploaded patch set 2 05/04/24, 07:46

  3. core-ci voted on patch set 1 V +1 05/04/24, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57199

  4. core-ci voted on patch set 2 V +1 05/04/24, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57200

  5. Sybille Peters uploaded patch set 3 V +1 05/04/24, 08:26

  6. core-ci voted on patch set 3 V +1 05/04/24, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57201

  7. Simon Schaufelberger uploaded patch set 4 V +1 09/10/24, 20:20

  8. core-ci voted on patch set 4 V +1 09/10/24, 20:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65343

  9. Simon Schaufelberger rebased onto patch set 5 V +1 09/11/24, 05:42

  1. core-ci voted on patch set 5 V +1 09/11/24, 05:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65372

  2. Garvin Hicking commented on patch set 6 V +1 09/11/24, 11:27

    Published edit on patch set 5.
  3. Garvin Hicking commented on patch set 7 09/11/24, 11:30

    Published edit on patch set 6.
  4. Garvin Hicking commented on patch set 8 09/11/24, 11:34

    Published edit on patch set 7.
  5. core-ci voted on patch set 6 V +1 09/11/24, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65421

  6. core-ci voted on patch set 7 V +1 09/11/24, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65422

  7. core-ci voted on patch set 8 V +1 09/11/24, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65423

  8. Sybille Peters uploaded patch set 9 V +1 09/11/24, 11:51

  9. Sybille Peters voted on patch set 9 CR +1 V +1 09/11/24, 11:55

  10. Garvin Hicking voted on patch set 9 CR +1 V +1 09/11/24, 11:57

  11. core-ci voted on patch set 9 V +1 09/11/24, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65429

  12. Thomas Hohn voted on patch set 9 CR +1 09/13/24, 07:56

  13. Sebastian Iffland commented on patch set 9 CR +1 09/13/24, 08:10

    PageLayoutController.php:501

    When using variable assign next to other conditions I'd prefer using parenthesis around. That makes handling with IDEs smoother, e.g. if at some point someones using `Flip '&&'` option. Further it's more clarifying, imo. But that's all about philosophy. Both works. ``` if ($returnUrl && ($closeButton = $this->makeCloseButton($buttonBar, $returnUrl))) { ```
  14. Sybille Peters commented on patch set 9 09/13/24, 08:23

    PageLayoutController.php:501 Reply

    I agree with you but I don't know how you are "supposed to" do it in the core. Idieally look in existing core code. Personally, I don't even like combining statements like these. It makes it more difficult to debug and is potentially error-prone in the future. Garvin?
  15. Garvin Hicking commented on patch set 10 CR +1 V +1 09/13/24, 08:24

    Published edit on patch set 9.
  16. Garvin Hicking commented on patch set 10 CR +1 V +1 09/13/24, 08:26

    PageLayoutController.php:501 Reply

    IMO the solution with parentheses is good. You could debate a long time about it, there are pro's and con's. we have both ways in the core, so I think we shouldn't put too much stress into it. For now I've just changed it to be part of the condition to prevent another nesting level. Thanks for the improvement!
  17. core-ci voted on patch set 10 V +1 09/13/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65635

  18. Sebastian Iffland commented on patch set 10 CR +1 09/13/24, 09:51

    LG™️
  19. Thomas Hohn voted on patch set 10 CR +1 09/13/24, 10:17

  20. Anja Leichsenring uploaded patch set 11 CR +1 V +1 09/14/24, 09:35

  21. Anja Leichsenring voted on patch set 11 CR +1 V +1 09/14/24, 09:36

  22. core-ci voted on patch set 11 V -1 09/14/24, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65749

  23. core-ci voted on patch set 11 V +1 09/14/24, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65749

  24. Garvin Hicking voted on patch set 11 CR +2 V +2 09/14/24, 10:23

  25. Garvin Hicking merged patch set 12 09/14/24, 10:23