84147[BUGFIX] Fix positioning of containers in EXT:styleguide BE module
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Frank Nägler +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Frank Nägler +1
- core-ci +1 CI
Issues 1
Files 22
- Build/Sources/Sass/module/_styleguide.scss+34 −25
- typo3/sysext/backend/Resources/Public/Css/backend.css+7 −6
- typo3/sysext/styleguide/Classes/Controller/BackendController.php+27 −36
- typo3/sysext/styleguide/Resources/Private/Partials/Backend/Navigation.html+12 −17
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Accordion.html+3 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Avatar.html+3 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Buttons.html2+4 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Cards.html+3 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Colors.html+3 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Filter.html+3 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/FlashMessages.html+2 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Icons.html+2 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Index.html+3 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Infobox.html+3 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Modal.html+3 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Notifications.html+3 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Pagination.html+3 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Shadows.html+3 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Tab.html+3 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Tables.html+3 −4
Review log 1826
Show 1 earlier messages
-
Andreas Kienast uploaded patch set 1 05/06/24, 07:47
-
Andreas Kienast uploaded patch set 2 05/06/24, 07:49
-
Andreas Kienast uploaded patch set 3 05/06/24, 07:50
-
core-ci voted on patch set 1 V +1 05/06/24, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57264
-
Andreas Kienast uploaded patch set 4 05/06/24, 07:53
-
core-ci voted on patch set 2 V +1 05/06/24, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57265
-
core-ci voted on patch set 3 V +1 05/06/24, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57266
-
core-ci voted on patch set 4 V +1 05/06/24, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57268
-
Benjamin Franzke commented on patch set 4 CR -1 05/06/24, 08:11
-
Benjamin Franzke uploaded patch set 5
CR -1V +105/06/24, 08:43 -
Benjamin Franzke commented on patch set 5 05/06/24, 08:43
styleguide is not in 12.4 branch -
Benjamin Franzke commented on patch set 5 05/06/24, 08:43
Buttons.html:14ReplyDone -
core-ci voted on patch set 5 V +1 05/06/24, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57269
-
Benjamin Franzke uploaded patch set 6
V +105/06/24, 09:18 -
core-ci voted on patch set 6 V +1 05/06/24, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57270
-
Andreas Kienast commented on patch set 6 V -1 05/06/24, 13:50
Navigation isn't sticky (for me). -
Benjamin Franzke uploaded patch set 7
CR +1V +105/06/24, 14:21 -
Benjamin Franzke voted on patch set 7 CR +1 V +1 05/06/24, 14:21
-
Andreas Kienast uploaded patch set 8
CR +1V +105/06/24, 14:24 -
Andreas Kienast voted on patch set 8 CR +1 V +1 05/06/24, 14:24
-
Benjamin Franzke voted on patch set 8 CR +1 V +1 05/06/24, 14:24
-
core-ci voted on patch set 7 V -1 05/06/24, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57289
-
core-ci voted on patch set 8 V +1 05/06/24, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57290
-
Frank Nägler voted on patch set 8 CR +1 V +1 05/08/24, 08:59
-
Andreas Kienast voted on patch set 8 CR +2 V +2 05/08/24, 08:59
-
Andreas Kienast merged patch set 9 05/08/24, 08:59
Buttons.html:14