Review main Merged

84147[BUGFIX] Fix positioning of containers in EXT:styleguide BE module

Andreas Kienast CR +2 V +2 Hard +133 −156 updated 05/08/24, 08:59

Commit message

The containers used in the backend module of EXT:styleguide are now
based on flex boxes and don't use absolute positioning anymore. This
enabled the possibility to scroll when the navigation needs more space
than the actual content and also fixes positioning in right-to-left
scenarios.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 22

Show 2 more files

Review log 1826

Show 1 earlier messages
  1. Andreas Kienast uploaded patch set 1 05/06/24, 07:47

  1. Andreas Kienast uploaded patch set 2 05/06/24, 07:49

  2. Andreas Kienast uploaded patch set 3 05/06/24, 07:50

  3. core-ci voted on patch set 1 V +1 05/06/24, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57264

  4. Andreas Kienast uploaded patch set 4 05/06/24, 07:53

  5. core-ci voted on patch set 2 V +1 05/06/24, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57265

  6. core-ci voted on patch set 3 V +1 05/06/24, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57266

  7. core-ci voted on patch set 4 V +1 05/06/24, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57268

  8. Benjamin Franzke commented on patch set 4 CR -1 05/06/24, 08:11

    Buttons.html:14

    indent
  9. Benjamin Franzke uploaded patch set 5 CR -1 V +1 05/06/24, 08:43

  10. Benjamin Franzke commented on patch set 5 05/06/24, 08:43

    styleguide is not in 12.4 branch
  11. Benjamin Franzke commented on patch set 5 05/06/24, 08:43

    Buttons.html:14 Reply

    Done
  12. core-ci voted on patch set 5 V +1 05/06/24, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57269

  13. Benjamin Franzke uploaded patch set 6 V +1 05/06/24, 09:18

  14. core-ci voted on patch set 6 V +1 05/06/24, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57270

  15. Andreas Kienast commented on patch set 6 V -1 05/06/24, 13:50

    Navigation isn't sticky (for me).
  16. Benjamin Franzke uploaded patch set 7 CR +1 V +1 05/06/24, 14:21

  17. Benjamin Franzke voted on patch set 7 CR +1 V +1 05/06/24, 14:21

  18. Andreas Kienast uploaded patch set 8 CR +1 V +1 05/06/24, 14:24

  19. Andreas Kienast voted on patch set 8 CR +1 V +1 05/06/24, 14:24

  20. Benjamin Franzke voted on patch set 8 CR +1 V +1 05/06/24, 14:24

  21. core-ci voted on patch set 7 V -1 05/06/24, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57289

  22. core-ci voted on patch set 8 V +1 05/06/24, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57290

  23. Frank Nägler voted on patch set 8 CR +1 V +1 05/08/24, 08:59

  24. Andreas Kienast voted on patch set 8 CR +2 V +2 05/08/24, 08:59

  25. Andreas Kienast merged patch set 9 05/08/24, 08:59