84152[BUGFIX] Add scheduler task exception to error message
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1924
-
Christian Weiske uploaded patch set 1 05/07/24, 11:55
-
core-ci voted on patch set 1 V +1 05/07/24, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57332
-
Benni Mack voted on patch set 1 CR +1 V +1 05/07/24, 15:17
-
Nikita Hovratov voted on patch set 1 CR +1 05/07/24, 15:28
-
Christoph Lehmann commented on patch set 1 05/08/24, 12:26
-
Christoph Lehmann commented on patch set 1 05/08/24, 12:31
Scheduler.php:173Reply(and the exception class) -
Andreas Kienast commented on patch set 1 05/08/24, 14:24
Scheduler.php:173ReplyFile and class are interchangeable, but logging the class is easier. -
Christian Weiske uploaded patch set 2
CR +1V +106/10/24, 12:01 -
core-ci voted on patch set 2 V +1 06/10/24, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59002
-
Christian Weiske commented on patch set 2 06/13/24, 11:50
The file name and line is included now, but not the class name. Not every crash is guranteed to have a class as a source.Scheduler.php:173ReplyDone -
Christoph Lehmann commented on patch set 3
V +106/15/24, 21:39Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 06/15/24, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59660
-
Benni Mack voted on patch set 3 CR +1 06/19/24, 20:49
-
Georg Ringer voted on patch set 3 CR +1 V +1 06/20/24, 06:08
-
Christian Kuhn commented on patch set 3 06/20/24, 16:17
hmpf. another regression we introduced with that logging patch :/ thanks for fixing! patch looks good, i just would like to remove v11 from the list for two reasons: * not a critical bug fix * does not apply cleanly in v11 since we rewrote so much scheduler code in v12 -
Christian Kuhn updated the commit message in patch set 4
CR +1V +106/20/24, 16:17 -
Christian Kuhn rebased onto patch set 5 06/20/24, 16:17
-
Christian Kuhn voted on patch set 5 CR +1 V +1 06/20/24, 16:17
-
core-ci voted on patch set 4 V +1 06/20/24, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59930
-
core-ci voted on patch set 5 V +1 06/20/24, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59931
-
Stefan Bürk voted on patch set 5 CR +1 V +1 06/20/24, 16:58
-
Christian Kuhn voted on patch set 5 CR +2 V +2 06/20/24, 17:03
-
Georg Ringer voted on patch set 5 CR +1 V +1 06/20/24, 18:50
-
Christian Kuhn merged patch set 6 06/20/24, 18:54
Scheduler.php:173