Review main Merged

84153[TASK] Avoid usage of ConnectionPool in extbase functional tests

Torben Hansen CR +2 V +2 Normal +35 −88 updated 05/07/24, 21:28

Commit message

This change changes extbase persistence tests to use CSV files
where suitable.

The `addSimpleObjectTest` has been removed, since
`addObjectSetsDefaultLanguageTest` also tests, if a simple object
can be added.

Additionally, one test is moved from `AddTest.php` to
`UpdateTest.php`, because this test actually tests an update-
scenario instead of an add-scenario.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 67

  1. Torben Hansen uploaded patch set 1 05/07/24, 16:39

  2. core-ci voted on patch set 1 V +1 05/07/24, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57359

  3. Benni Mack voted on patch set 1 CR +1 V +1 05/07/24, 16:44

  4. Oliver Klee voted on patch set 1 V +1 05/07/24, 19:54

  5. Oliver Klee voted on patch set 1 CR +1 05/07/24, 19:54

  6. Benni Mack voted on patch set 1 CR +2 V +2 05/07/24, 21:28

  7. Benni Mack merged patch set 2 05/07/24, 21:28