Review main Merged

84176[TASK] Don't redraw workspace table on search input focus

Willi Wehmeier CR +2 V +2 Easy +3 −4 updated 08/08/24, 16:30

Commit message

Avoid fetching and redrawing the record overview table when
the search term input field gets focussed. This prevents
breaking the ui state and unwanted deselecting of rows.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2226

Show 1 earlier messages
  1. Willi Wehmeier uploaded patch set 1 05/08/24, 07:29

  1. core-ci voted on patch set 1 V -1 05/08/24, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57395

  2. Willi Wehmeier uploaded patch set 2 V -1 05/08/24, 08:03

  3. core-ci voted on patch set 2 V +1 05/08/24, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57398

  4. Benni Mack voted on patch set 2 CR +1 07/12/24, 20:53

  5. Christian Rath-Ulrich voted on patch set 2 CR +1 V +1 07/17/24, 15:38

  6. Georg Ringer voted on patch set 2 CR +1 V +1 07/17/24, 19:20

  7. Patrick Schriner voted on patch set 2 CR +1 V +1 08/01/24, 19:19

  8. Christian Kuhn voted on patch set 2 CR +1 08/06/24, 13:09

  9. Andreas Kienast commented on patch set 2 CR -1 08/06/24, 13:11

    backend.ts:269

    Can't we listen to `input` instead? IIRC this doesn't emit on pressing <TAB>.
  10. Andreas Kienast commented on patch set 2 08/06/24, 13:12

    backend.ts:269 Reply

    While on it, I'd like to use DebounceEvent instead to avoid reacting on every input if the user is a fast writer.
  11. Andreas Kienast uploaded patch set 3 CR +1 V +1 08/06/24, 13:16

  12. Andreas Kienast commented on patch set 3 CR +1 V +1 08/06/24, 13:16

    backend.ts:269 Reply

    DebounceEvent doesn't make much sense here...
  13. core-ci voted on patch set 3 V +1 08/06/24, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62938

  14. Benni Mack voted on patch set 3 CR +1 08/06/24, 13:28

  15. Patrick Schriner voted on patch set 3 V +1 08/06/24, 13:31

  16. Christian Kuhn voted on patch set 3 CR +1 V +1 08/06/24, 13:35

  17. Chris Müller voted on patch set 3 V +1 08/07/24, 17:09

  18. Christian Kuhn commented on patch set 3 08/08/24, 16:07

    this is merge ready and i re-tested in main. v12 has the same issue but i fail to prepare the v12 backport due to the no-jquery changes in main. i asked andy to pick this up.
  19. Andreas Kienast commented on patch set 3 V 0 CR -1 08/08/24, 16:22

    I've overridden the original author by accident, will re-push
  20. Andreas Kienast rebased onto patch set 4 CR +1 V +1 08/08/24, 16:22

  21. Andreas Kienast voted on patch set 4 CR +1 V +1 08/08/24, 16:22

  22. Christian Kuhn voted on patch set 4 CR +1 V +1 08/08/24, 16:23

  23. core-ci voted on patch set 4 V +1 08/08/24, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63064

  24. Christian Kuhn voted on patch set 4 CR +2 V +2 08/08/24, 16:30

  25. Christian Kuhn merged patch set 5 08/08/24, 16:30