84178[TASK] Add SiteConfigurationChangedEvent
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 811
-
Willi Wehmeier uploaded patch set 1 05/08/24, 09:32
-
Willi Wehmeier updated the commit message in patch set 2 05/08/24, 09:33
-
Willi Wehmeier updated the commit message in patch set 3 05/08/24, 09:35
-
core-ci voted on patch set 2 V +1 05/08/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57404
-
core-ci voted on patch set 1 V +1 05/08/24, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57403
-
core-ci voted on patch set 3 V +1 05/08/24, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57405
-
Benjamin Franzke commented on patch set 1 CR -2 05/08/24, 09:47
Copied votes on follow-up patch sets have been updated: * Code-Review-2 has been copied to patch set 2, 3 (copy condition: "changekind:NO_CHANGE OR is:MIN").`SiteConfigurationChangedEvent` was added in v13 as `@internal` event to be able to invalidate runtime caches in https://review.typo3.org/c/Packages/TYPO3.CMS/+/83557 This is not intended as public API. -
Benjamin Franzke commented on patch set 3 CR -2 05/08/24, 09:50
Reply
Posted an alternative suggestion for the issue in https://forge.typo3.org/issues/103804#note-4 -
Simon Schaufelberger commented on patch set 3 05/08/24, 11:49
Reply
could you then abandon this change if it won't get merged? -
Willi Wehmeier abandoned the change 05/08/24, 12:07
We'll try another approach without adding the internal event from v13 -
Simon Schaufelberger commented on patch set 3 05/08/24, 15:42
Reply
Done