Review main Merged

84181[BUGFIX] Allow Resources/Public within asset paths

Markus Klein CR +2 V +2 Easy +2 −1 updated 05/10/24, 07:18

Commit message

"Resources/Public" may occur also within an
asset path. Path detection code must therefore
only check for its first occurrence.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Josef Glatz +1
    • Kevin Appelt +1
    • Garvin Hicking +1
    • Willi Wehmeier +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Josef Glatz +1
    • Garvin Hicking +1
    • Willi Wehmeier +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Markus Klein uploaded patch set 1 05/08/24, 17:04

  2. core-ci voted on patch set 1 V +1 05/08/24, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57413

  3. Markus Klein uploaded patch set 2 V +1 05/08/24, 17:13

  4. Markus Klein marked it ready for review 05/08/24, 17:14

  5. Kevin Appelt voted on patch set 2 CR +1 05/08/24, 17:18

  6. core-ci voted on patch set 2 V +1 05/08/24, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57414

  7. Garvin Hicking commented on patch set 2 CR +1 V +1 05/08/24, 18:35

    This looks like an unintrusive patch to me - I'm stumped I totally misread the issue at first sight, thanks so much for getting it on track! Think this edge-case may not need a specific test and is isolated enough. Verified working for me in a test setup.
  8. Josef Glatz voted on patch set 2 CR +1 V +1 05/08/24, 19:26

  9. Willi Wehmeier voted on patch set 2 CR +1 V +1 05/10/24, 05:46

  10. Mathias Brodala commented on patch set 2 05/10/24, 06:48

    PathUtility.php:70

    As usual I'd love to see "limit: 2" instead here. This way I don't need to remember/look up what this seemingly magic number does.
  11. Garvin Hicking commented on patch set 2 05/10/24, 06:56

    PathUtility.php:70 Reply

    (Note that the "named arguments" primer says "It is allowed for functions with more than three arguments." so it wouldn't apply to explode() here with the current CGL. I mention that without prejudice ;))
  12. Benjamin Franzke commented on patch set 2 CR +2 V +2 05/10/24, 07:18

  13. Benjamin Franzke merged patch set 3 05/10/24, 07:18