84183[DOCS] Add sprintf() reference to f:translate ViewHelper documentation
Commit message
Review
-
Code review CR +2 Done
- Lina Wolf +2
- Markus Klein +1
-
Verified V +2 Done
- Lina Wolf +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 1
Review log 912
-
Garvin Hicking uploaded patch set 1 05/08/24, 20:42
-
core-ci voted on patch set 1 V +1 05/08/24, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57417
-
Lina Wolf commented on patch set 1 05/09/24, 06:34
We need to use Markdown, not rst hereTranslateViewHelper.php:93We cannot use rst syntax here, but must use Markdown. The Markdown is then transfered into rst in https://github.com/TYPO3-Documentation/fluid-documentation-generator -
Garvin Hicking uploaded patch set 2
V +105/09/24, 07:30Adjust link -
Garvin Hicking commented on patch set 2 05/09/24, 07:35
Reply
The other Viewhelpers utilize :php: and :html: as well and get properly rendered/interpreted, so I think this usage is inline with that and should not deviate.TranslateViewHelper.php:93ReplyI adjusted my use of the link syntax to be in line with other ViewHelpers (f:security.IfHasRole, f:format:html) so it should be treated like the others. We talked about this on Slack - if this format should be converted from RST to Markdown in the ViewHelpers, we should do that in a seperate patch/issue. For now we'll keep it in line. -
core-ci voted on patch set 2 V +1 05/09/24, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57439
-
Lina Wolf voted on patch set 2 CR +1 V +1 05/09/24, 07:41
-
Markus Klein updated the commit message in patch set 3
CR +1V +105/09/24, 08:30 -
Markus Klein voted on patch set 3 CR +1 V +1 05/09/24, 08:31
-
Lina Wolf voted on patch set 3 CR +2 V +2 05/09/24, 08:35
-
core-ci voted on patch set 3 V +1 05/09/24, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57440
-
Lina Wolf merged patch set 4 05/09/24, 08:35