Review main Merged

84215[TASK] Remove unused line from YamlSetDefinitionProvider

Stefan Froemken CR +2 V +2 Easy +0 −1 updated 05/13/24, 06:09

Commit message

Remove line which extracts a version number
from YamlSetDefinitionProvider as settings
definitions does not contain any version number.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Stefan Froemken uploaded patch set 1 05/12/24, 19:19

  2. core-ci voted on patch set 1 V +1 05/12/24, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57553

  3. Benjamin Franzke voted on patch set 1 CR +1 V +1 05/13/24, 05:59

  4. Benjamin Franzke commented on patch set 1 05/13/24, 06:00

    ack, it was a leftover from earlier patchsets.
  5. Andreas Kienast voted on patch set 1 CR +2 V +2 05/13/24, 06:09

  6. Andreas Kienast merged patch set 2 05/13/24, 06:09