Review 12.4 Merged

84216[BUGFIX] Circumvent possible race condition in cache retrieval

Benjamin Franzke CR +2 V +2 Easy +36 −7 updated 05/13/24, 07:01

Commit message

To circumvent race conditions where the cache is removed between
`has()` and `require()` invocations, the return value of the
cache result needs to be verified, as `false` is returned if
the cache entry is not available.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Benjamin Franzke uploaded patch set 1 05/13/24, 06:41

  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 05/13/24, 06:42

  3. core-ci voted on patch set 1 V +1 05/13/24, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57575

  4. Benjamin Franzke merged patch set 2 05/13/24, 07:01