84228[BUGFIX] Enhance duplicate source detection for auto-redirect creation
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Albrecht Köhnlein +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Albrecht Köhnlein +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst2+6 −2
- typo3/sysext/redirects/Classes/EventListener/AddPageTypeZeroSource.php2+1 −1
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/SlugServiceTest_defaultSlashPageTypeSuffixCreatesOnlyPageTypeZeroSourceRedirect.csvnew+4 −0
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php+61 −5
Review log 1517
-
Stefan Bürk uploaded patch set 1 05/13/24, 10:07
-
core-ci voted on patch set 1 V +1 05/13/24, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57603
-
Stefan Bürk wrote 05/13/24, 11:23
Topic set to Red -
Stefan Bürk wrote 05/13/24, 11:23
Topic Red removed -
Stefan Bürk wrote 05/13/24, 11:23
Topic set to Redirects -
Stefan Bürk updated the commit message in patch set 2
V +105/13/24, 11:39 -
core-ci voted on patch set 2 V +1 05/13/24, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57615
-
Stefan Bürk voted on patch set 2 CR -2 05/13/24, 16:22
-
Stefan Bürk voted on patch set 2 CR 0 05/13/24, 16:33
-
Georg Ringer voted on patch set 2 CR +1 V +1 05/13/24, 18:13
-
Nikita Hovratov voted on patch set 2 CR +1 V +1 05/13/24, 19:06
-
Nikita Hovratov commented on patch set 2 05/13/24, 19:08
Just a note: It's trailing not tailing. -
Albrecht Köhnlein commented on patch set 2 CR -1 V -1 05/13/24, 19:13
Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:127Unfortunatelym this only works with page suffix '/' but not with other suffixes like '.html' -
Albrecht Köhnlein commented on patch set 2 05/13/24, 19:17
Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:127ReplySorry. I commented the wrong line, I guess.AddPageTypeZeroSource.php:85Unfortunately this only works with page suffix '/' but not with other suffixes like '.html' -
Albrecht Köhnlein commented on patch set 2 CR +1 V +1 05/13/24, 19:34
AddPageTypeZeroSource.php:85ReplyClarified via slack. The difference is intended. -
Stefan Bürk voted on patch set 2 CR +2 V +2 05/13/24, 19:46
-
Stefan Bürk merged patch set 3 05/13/24, 20:08