84229[BUGFIX] Build correct PageTypeZeroSource for hidden or scheduled pages
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Garvin Hicking +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 4
Files 8
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst+19 −2
- typo3/sysext/redirects/Classes/EventListener/AddPageTypeZeroSource.php+23 −1
- typo3/sysext/redirects/Classes/EventListener/AddPlainSlugReplacementSource.php+3 −0
- typo3/sysext/redirects/Classes/RedirectUpdate/SlugRedirectChangeItemFactory.php+1 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/SlugServiceTest_endtime.csvnew+4 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/SlugServiceTest_hiddenPage.csvnew+4 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/SlugServiceTest_starttime.csvnew+4 −0
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php+90 −0
Review log 1418
-
Stefan Bürk uploaded patch set 1 05/13/24, 11:22
-
Stefan Bürk wrote 05/13/24, 11:22
Topic set to Redirects -
core-ci voted on patch set 1 V -1 05/13/24, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57611
-
Stefan Bürk updated the commit message in patch set 2
V -105/13/24, 11:39 -
core-ci voted on patch set 2 V -1 05/13/24, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57614
-
Stefan Bürk uploaded patch set 3
V -105/13/24, 11:48 -
core-ci voted on patch set 3 V +1 05/13/24, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57616
-
Stefan Bürk voted on patch set 3 CR -2 05/13/24, 16:22
-
Stefan Bürk commented on patch set 3 05/13/24, 16:35
``` @param bool $includeScheduledRecords whether to ignore access time in tables except for pages ``` VisibilityAspect->includeScheduledRecords does not count for pages. Needs deeper investigation how to create a link for such pages in that case. -
Stefan Bürk uploaded patch set 4
V +105/13/24, 17:49Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Stefan Bürk commented on patch set 4 CR -2 05/13/24, 17:50
Reply
Blocked until I2e7f038a04d957751bba1181c3d5324c6e0674b5 has been merged. -
core-ci voted on patch set 4 V +1 05/13/24, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57639
-
Georg Ringer voted on patch set 4 CR +1 V +1 05/13/24, 18:12
-
Stefan Bürk voted on patch set 4 CR 0 05/13/24, 19:36
-
Stefan Bürk commented on patch set 4 05/13/24, 20:09
Reply
Done -
Garvin Hicking commented on patch set 4 CR +1 V +1 05/13/24, 21:17
true, true, false, true, up up, down down, left right, left right, a b a b select start. scnr. -
Stefan Bürk voted on patch set 4 CR +2 V +2 05/13/24, 22:00
-
Stefan Bürk merged patch set 5 05/13/24, 22:18