Review main Merged

84231[BUGFIX] Cast port to integer when setting up the database

Benni Mack CR +2 V +2 Easy +3 −0 updated 05/13/24, 19:23

Commit message

Ensure env variable from port is cast to integer
when setting up TYPO3 with Environment variable
TYPO3_INSTALL_DB_PORT.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Rafael Kähm +1
    • Markus Friedrich +1
    • Stefan Bürk +1
    • Jörg Bösche +1
    • Andreas Kienast +1
    • Willi Wehmeier +1
  • Verified V +2 Done
    • Benni Mack +2
    • Rafael Kähm +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1112

  1. Benni Mack uploaded patch set 1 05/13/24, 13:10

  2. Rafael Kähm voted on patch set 1 CR +1 V +1 05/13/24, 13:11

  3. Markus Friedrich voted on patch set 1 CR +1 05/13/24, 13:16

  4. core-ci voted on patch set 1 V +1 05/13/24, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57623

  5. Nikita Hovratov commented on patch set 1 05/13/24, 13:22

    backport is not necessariliy needed as this has something to do with doctrine v4.
  6. Andreas Kienast voted on patch set 1 CR +1 05/13/24, 13:23

  7. Oliver Klee voted on patch set 1 CR +1 05/13/24, 13:35

  8. Jörg Bösche voted on patch set 1 CR +1 05/13/24, 13:59

  9. Willi Wehmeier voted on patch set 1 CR +1 05/13/24, 14:20

  10. Stefan Bürk voted on patch set 1 CR +1 V +1 05/13/24, 19:17

  11. Benni Mack commented on patch set 1 CR +2 V +2 05/13/24, 19:23

    @nikita: as this is the proper casting value, I will still add this to v12, hope that's OK.
  12. Benni Mack merged patch set 2 05/13/24, 19:23