Review main Merged

84233[TASK] Upgrade bacon/bacon-qr-code to v3

Benni Mack CR +2 V +2 Easy +20 −20 updated 05/14/24, 18:16

Commit message

This new version drops support for PHP 8.0 and below
https://github.com/Bacon/BaconQrCode/releases/tag/v3.0.0

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • Andreas Kienast +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 810

  1. Benni Mack uploaded patch set 1 05/13/24, 15:21

  2. core-ci voted on patch set 1 V +1 05/13/24, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57626

  3. Benni Mack updated the commit message in patch set 2 V +1 05/14/24, 12:32

  4. core-ci voted on patch set 2 V +1 05/14/24, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57707

  5. Oliver Hader voted on patch set 2 CR +1 05/14/24, 12:56

  6. Oliver Hader voted on patch set 2 V +1 05/14/24, 13:04

  7. Andreas Kienast voted on patch set 2 CR +1 V +1 05/14/24, 14:44

  8. Torben Hansen commented on patch set 2 CR +1 V +1 05/14/24, 16:18

    Very cool the new version has `GDLibRenderer` which allows to create QR code images (e.g. pngs)
  9. Benni Mack commented on patch set 2 CR +2 V +2 05/14/24, 18:16

    Reply

    I'd always prefer SVG over PNG, but yes. Read that too, cool feature.
  10. Benni Mack merged patch set 3 05/14/24, 18:16