Review 12.4 Merged

84234[BUGFIX] Make CE actions clickable after edit or visibility toggle

Benjamin Franzke CR +2 V +2 Easy +5 −18 updated 05/13/24, 16:09

Commit message

When a content element (CE) gets edited or the visibility is toggled,
the page module is reloaded with an anchor in the URL to scroll to the
content element that was updated.

After #103381 it was not possible anymore to click the "+ Content"
button above such CE. The reason is that a pseudo element
`:target:before` is generated with a specific height and margin to
overcome the height of the floating module docheader, overlaying the
CE action button.
In the patch mentioned before, `overflow: hidden` was removed to make
the `box-shadow` of the CE visible, finally causing this bug.

To solve this issue the pseudo element add it #97036 is replaced by the
CSS option scroll-padding-top. It incorperates the maximum docheader
size plus a slight margin that is slightly lower than the grid margin –
but not equal to – to move shadows of adjacent elements out of sight.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 3

Files 4

Review log 23

  1. Benjamin Franzke uploaded patch set 1 05/13/24, 16:03

  2. core-ci voted on patch set 1 V +1 05/13/24, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57629

  3. Benjamin Franzke merged patch set 2 05/13/24, 16:09