Review main Merged

84235[BUGFIX] Add related visibility options for PageRepository cacheIdentifier

Stefan Bürk CR +2 V +2 Easy +16 −2 updated 05/13/24, 19:30

Commit message

Since #102793 the PageRepository respects `includeScheduledRecords`
from the context `VisibilityAspect` setting in the `PageRepository`
and added a runtime cache  handling in the `init()` call. However,
the cache identifier does not respect the same visibilty options
for the cache identifier like it is used for preparing the property
`where_hid_del` - and thus leads to invalid and unexpected record
retrievement, depending on context switches in a request.

This change extends the cache identifier to respect the scheduled
record setting and removes the invalid page table except comment.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 710

  1. Stefan Bürk uploaded patch set 1 05/13/24, 17:39

  2. Stefan Bürk uploaded patch set 2 05/13/24, 17:41

  3. core-ci voted on patch set 1 V -1 05/13/24, 17:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57636

  4. core-ci voted on patch set 2 V +1 05/13/24, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57637

  5. Stefan Bürk uploaded patch set 3 05/13/24, 17:49

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  6. core-ci voted on patch set 3 V +1 05/13/24, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57638

  7. Georg Ringer voted on patch set 3 CR +1 V +1 05/13/24, 18:06

  8. Benni Mack voted on patch set 3 CR +1 V +1 05/13/24, 18:59

  9. Stefan Bürk voted on patch set 3 CR +2 V +2 05/13/24, 19:27

  10. Stefan Bürk merged patch set 4 05/13/24, 19:30