Review 12.4 Merged

84236[BUGFIX] Add related visibility options for PageRepository cacheIdentifier

Stefan Bürk CR +2 V +2 Easy +20 −2 updated 05/13/24, 19:44

Commit message

Since #102793 the PageRepository respects `includeScheduledRecords`
from the context `VisibilityAspect` setting in the `PageRepository`
and added a runtime cache  handling in the `init()` call. However,
the cache identifier does not respect the same visibilty options
for the cache identifier like it is used for preparing the property
`where_hid_del` - and thus leads to invalid and unexpected record
retrievement, depending on context switches in a request.

This change extends the cache identifier to respect the scheduled
record setting and removes the invalid page table except comment.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Stefan Bürk uploaded patch set 1 05/13/24, 19:36

  2. core-ci voted on patch set 1 V +1 05/13/24, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57641

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 05/13/24, 19:44

  4. Stefan Bürk merged patch set 2 05/13/24, 19:44