Review main Merged

84237[BUGFIX] Prevent creation of orphaned records in copy process

André Buchmann CR +2 V +2 Easy +20 −26 updated 05/25/24, 10:16

Commit message

When records are copied, DataHandler copies its localizations as
well. This is good, but can lead to "orphan" localization records
if the target page a record is copied to is not localized to that
language.

This is inconsistent and leads to various headaches with access
rights and when localized records are synchronized later.
Also, such localized records suddenly appear, when the parent
page is localized to the missing target language, which is an
unexpected behavior for BE editors.

The patch changes this by skipping copying localizations of
records when the target page is not localized to that language.

Note DH method copyL10nOverlayRecords() will receive another
clean up with another patch to rule out some shenanigans we
stumbled upon when implementing this solution.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 811

  1. André Buchmann uploaded patch set 1 05/13/24, 20:56

  2. core-ci voted on patch set 1 V -1 05/13/24, 21:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57649

  3. André Buchmann uploaded patch set 2 V -1 05/14/24, 07:56

  4. core-ci voted on patch set 2 V +1 05/14/24, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57683

  5. Astrid Haubold voted on patch set 2 CR +1 05/17/24, 09:15

  6. Christian Kuhn uploaded patch set 3 CR +1 V +1 05/25/24, 09:22

  7. core-ci voted on patch set 3 V +1 05/25/24, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58199

  8. Christian Kuhn voted on patch set 3 CR +1 V +1 05/25/24, 09:41

  9. Anja Leichsenring voted on patch set 3 CR +1 V +1 05/25/24, 10:14

  10. Christian Kuhn voted on patch set 3 CR +2 V +2 05/25/24, 10:16

  11. Christian Kuhn merged patch set 4 05/25/24, 10:16