Review 11.5 Merged

84256[SECURITY] Protect frame GET parameter in tx_cms_showpic eID

Oliver Hader CR +2 V +2 Easy +43 −1 updated 05/14/24, 08:48

Commit message

The "frame" parameter is no longer evaluated in the showpic eID as
it allowed uncontrolled resource consumption. This parameter was
actually never used by ContentObjectRenderer and existed since
the initial commit and is therefore put behind a feature flag.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 4

Review log 34

  1. Oliver Hader uploaded patch set 1 05/14/24, 08:01

  2. Oliver Hader commented on patch set 1 CR +2 V +2 05/14/24, 08:01

    Auto-approved
  3. Oliver Hader merged patch set 2 05/14/24, 08:01

  4. core-ci voted on patch set 1 V +1 05/14/24, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57686