Review main Abandoned

84280[WIP][TASK] Include Git revision in package cache identifier

Andreas Kienast CR 0 V 0 Easy +32 −1 updated 06/20/24, 10:23

Commit message

In development contexts it is handy to have a git revision-aware cache
identifier to avoid the need of manual cache clearing.

This commit now introduces such additional metric, if TYPO3 runs in a
`-dev` version and runs in development context.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 810

  1. Andreas Kienast uploaded patch set 1 05/15/24, 08:25

  2. Andreas Kienast uploaded patch set 2 05/15/24, 08:43

  3. Andreas Kienast uploaded patch set 3 05/23/24, 06:43

  4. Andreas Kienast wrote 05/23/24, 06:44

    Unset private
  5. core-ci voted on patch set 3 V +1 05/23/24, 06:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58095

  6. Andreas Kienast uploaded patch set 4 V +1 05/23/24, 07:13

  7. core-ci voted on patch set 4 V +1 05/23/24, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58096

  8. Christian Kuhn commented on patch set 4 CR -1 05/23/24, 07:25

    mmmh. this is for monorepo development only, right? since that git command is run in monorepo-clone-root because somehow that's the base directory of web requests? isn't this a bit of an overkill? shouldn't we require from core-devs to actually flush cashes when either working in such a related area that affects caches, and after pulling in new changes? also, when this is merged and kicks in, it will lead to the situation that multiple cache files accumulate over time and make the system even harder to understand when lots of old cache files (especially for central stuff like core system cache) are lying around ... apart from that ... running a git command via exec() to then include this as cache hash really does not feel good and i'd love to avoid this in general.

    Environment.php:337 Unresolved

    in which directory is this git command executed?
  9. Patrick Schriner commented on patch set 4 05/23/24, 09:26

    Unresolved

    Super cool idea, Can we extend it with an event? I'd love to be able the container hash in a clustered / docker / kubernetes environment to the cache identifier.
  10. Andreas Kienast abandoned the change 06/20/24, 10:23