Review main Merged

84281[TASK] Update ckeditor to 41.4

Andreas Kienast CR +2 V +2 Expert +1448 −755 updated 06/04/24, 07:25

Commit message

This commit updates ckeditor to 41.4. See changelog at [1].

Executed commands:

    # Override ckeditor5 package to avoid pulling in all/too
    # many available packages. See:
    # https://github.com/ckeditor/ckeditor5/issues/16360
    npm --prefix overrides/ckeditor5 version 41.4.2
    npm install --save ./overrides/ckeditor5

    npm install --save \
        @ckeditor/ckeditor5-alignment@^41.4.2 \
        @ckeditor/ckeditor5-autoformat@^41.4.2 \
        @ckeditor/ckeditor5-basic-styles@^41.4.2 \
        @ckeditor/ckeditor5-block-quote@^41.4.2 \
        @ckeditor/ckeditor5-clipboard@^41.4.2 \
        @ckeditor/ckeditor5-code-block@^41.4.2 \
        @ckeditor/ckeditor5-core@^41.4.2 \
        @ckeditor/ckeditor5-editor-classic@^41.4.2 \
        @ckeditor/ckeditor5-engine@^41.4.2 \
        @ckeditor/ckeditor5-essentials@^41.4.2 \
        @ckeditor/ckeditor5-find-and-replace@^41.4.2 \
        @ckeditor/ckeditor5-font@^41.4.2 \
        @ckeditor/ckeditor5-heading@^41.4.2 \
        @ckeditor/ckeditor5-horizontal-line@^41.4.2 \
        @ckeditor/ckeditor5-html-support@^41.4.2 \
        @ckeditor/ckeditor5-indent@^41.4.2 \
        @ckeditor/ckeditor5-link@^41.4.2 \
        @ckeditor/ckeditor5-list@^41.4.2 \
        @ckeditor/ckeditor5-paragraph@^41.4.2 \
        @ckeditor/ckeditor5-paste-from-office@^41.4.2 \
        @ckeditor/ckeditor5-remove-format@^41.4.2 \
        @ckeditor/ckeditor5-select-all@41.4.2 \
        @ckeditor/ckeditor5-show-blocks@^41.4.2 \
        @ckeditor/ckeditor5-source-editing@^41.4.2 \
        @ckeditor/ckeditor5-special-characters@^41.4.2 \
        @ckeditor/ckeditor5-style@^41.4.2 \
        @ckeditor/ckeditor5-table@^41.4.2 \
        @ckeditor/ckeditor5-theme-lark@^41.4.2 \
        @ckeditor/ckeditor5-ui@^41.4.2 \
        @ckeditor/ckeditor5-undo@^41.4.2 \
        @ckeditor/ckeditor5-upload@^41.4.2 \
        @ckeditor/ckeditor5-utils@^41.4.2 \
        @ckeditor/ckeditor5-watchdog@^41.4.2 \
        @ckeditor/ckeditor5-word-count@^41.4.2
    npm install --save-dev \
        @ckeditor/ckeditor5-dev-utils@^40.0.0
    npm run build

[1] https://github.com/ckeditor/ckeditor5/releases/tag/v41.4.2

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 99

Show 79 more files

Review log 1116

  1. Andreas Kienast uploaded patch set 1 05/15/24, 09:19

  2. core-ci voted on patch set 1 V +1 05/15/24, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57768

  3. Andreas Kienast commented on patch set 1 CR -2 05/15/24, 09:32

    Something in ckeditor changed and bloats our build.
  4. Benjamin Franzke commented on patch set 1 05/15/24, 10:09

    Reply

    Let's ask upstream https://github.com/ckeditor/ckeditor5/issues/16360 But I guess they already noticed: https://github.com/ckeditor/ckeditor5/releases/tag/v41.4.0 > *Caution* > > This release has known issues, as detected by our end-to-end tests. It will not be automatically installed unless you are using a tag other than latest. We are working on fixes and will update you soon. Stay tuned!
  5. Benjamin Franzke uploaded patch set 2 V +1 05/17/24, 08:07

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  6. core-ci voted on patch set 2 V -1 05/17/24, 08:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57856

  7. Benjamin Franzke uploaded patch set 3 V -1 05/21/24, 06:53

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  8. core-ci voted on patch set 3 V -1 05/21/24, 06:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57979

  9. Benjamin Franzke uploaded patch set 4 V -1 05/21/24, 07:14

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  10. Benjamin Franzke uploaded patch set 5 CR +1 V +1 05/21/24, 07:16

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  11. core-ci voted on patch set 4 V +1 05/21/24, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57981

  12. core-ci voted on patch set 5 V +1 05/21/24, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57982

  13. Andreas Kienast voted on patch set 5 CR 0 05/21/24, 08:18

  14. Benni Mack voted on patch set 5 CR +1 V +1 06/03/24, 21:23

  15. Andreas Kienast voted on patch set 5 CR +2 V +2 06/04/24, 07:25

  16. Andreas Kienast merged patch set 6 06/04/24, 07:25