84282[DOCS] Improve "_assets" composer directory migration issues
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Chris Müller +1
- Nikita Hovratov +1
- André Buchmann +1
-
Verified V +2 Done
- Stefan Bürk +2
- Chris Müller +1
- Nikita Hovratov +1
- André Buchmann +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2632
Show 57 earlier messages
-
Garvin Hicking uploaded patch set 1 05/15/24, 14:37
-
core-ci voted on patch set 1 V +1 05/15/24, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57776
-
André Buchmann commented on patch set 1 05/15/24, 14:59
Very nicely written! Thank you very much Some minor improvements: Once you write 'future TYPO3 major versions' and the other time 'future major TYPO3 versions' Maybe also the sentence is a duplicate?Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:17plural: files from extensionsImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:23a directory called :file:`_assets/` -
Garvin Hicking uploaded patch set 2
V +105/15/24, 15:25apply suggestions -
Garvin Hicking commented on patch set 2 05/15/24, 15:27
Reply
Thanks! :) Indeed that was some redundancy I was't sure how to address. I didn't want to say "as mentioned above" to prevent looking scrolling, and the note is so short. For now I've just unfied this to read "future TYPO3 major versions". Maybe alternate suggestions popup for this, so I leave this unresolved for now.Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:17ReplyDoneImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:23ReplyDone -
core-ci voted on patch set 2 V +1 05/15/24, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57777
-
Stefan Bürk voted on patch set 2 CR +1 V +1 05/15/24, 16:01
-
Chris Müller commented on patch set 2 CR -1 05/15/24, 17:21
Well done 👍Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:18No need for the "(s)". HTTP is the protocol - not the scheme, so just use HTTP.Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:20images/icons (lowercase)Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:26MD5 hash (without dash)Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:28composer -> Composer (common name)Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:33Personally, would remove the preceding slash before public to avoid confusion with absolute path.Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:34Here too (avoid preceding slash).Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:35And here (avoid preceding slash).Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:42"JavaScipt files" (without dash)Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:43Avoid preceding slash in pathImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:47Dow we now have a fluid text role?Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:60Had to read this sentence multiple times to get what is meant, maybe write it better?Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:74Alternative -> AlternativelyImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:82Not only that, it also changes currently when using another vendor folder than "vendor" (as this is taken int account for the MD% hash). So a developer changing that for whatever reason may break integrator's work.Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:83composer -> ComposerImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:91Thanks for linking 😊Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:92use a :ref: here -
Garvin Hicking uploaded patch set 3
CR +1V +105/15/24, 19:49Apply suggestions from code review -
Garvin Hicking commented on patch set 3 05/15/24, 19:50
Thanks @typo3@brotkrueml.dev for the eagle eyes, addressed your suggestions! :)Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:18ReplyDoneImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:20ReplyDoneImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:26ReplyDoneImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:28ReplyDoneImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:33ReplyDoneImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:34ReplyDoneImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:35ReplyDoneImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:42ReplyDoneImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:43ReplyDoneImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:47ReplyDon't now if it's new, but yes, it exists and gets rendered :-)Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:60ReplyI see. I tried to shorten the sentence and reword it a bit to get my idea across, did that help?Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:74ReplyThanks, actually I reworded the sentence because I think it also was not clear enough.Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:82ReplyGood addition, I tried to address this with another sentence.Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:83ReplyDoneImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:92ReplyCould you remind me again; the docs often use absolute links to docs.typo3.org - when do I use an absolute link and when a reference? Are the absolute link places just an oversight? (e.g. in Feature-94625) -
core-ci voted on patch set 3 V +1 05/15/24, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57787
-
Garvin Hicking uploaded patch set 4
V +105/15/24, 19:55 -
core-ci voted on patch set 4 V +1 05/15/24, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57788
-
Nikita Hovratov commented on patch set 4 05/15/24, 20:43
Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:28itsImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:48You probably meant stdWrap insertData in combination with data `path` https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Functions/Data.html#path I would mention this data getter as the primary method in TypoScript. -
Christoph Lehmann commented on patch set 4 05/15/24, 21:05
Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:79May mention EXT:typo3_console ? It has a command to get all paths ./bin/typo3 frontend:asseturl +-------------------------+--------------------------------------------+ | extension key | asset URL | +-------------------------+--------------------------------------------+ | core | /_assets/1ee1d3e909b58d32e30dcea666dd3224/ | -
Garvin Hicking commented on patch set 4 05/15/24, 21:15
Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:79ReplyThat's a good idea, I would however prefer to add this to the Documentation port later, to keep the ChangeLog here with a "vital" scope? The extensions can be retrieved by inspecting the symlinks so it would be more of a convenience method to mention later? -
André Buchmann commented on patch set 4 05/16/24, 06:22
Reply
I'm fine with the unification and having it twice as it's a kinda long text with a lot of informations. -
Garvin Hicking uploaded patch set 5
V +105/16/24, 06:38Apply suggestions from code review -
Garvin Hicking commented on patch set 5 05/16/24, 06:38
Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:28ReplyDoneImportant-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:48ReplyYes, I improved this by also linking to the specific functions now. -
core-ci voted on patch set 5 V +1 05/16/24, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57822
-
André Buchmann voted on patch set 5 CR +1 V +1 05/16/24, 07:16
-
Chris Müller commented on patch set 5 CR -1 05/16/24, 07:51
Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:60Reply"You can use ... to generated variables" -> better: "You can use ... to create variables"? Does that fit what you want to say? Additionally, in the second line you have a superfluous colon before EXT:... -
Christoph Lehmann commented on patch set 5 05/16/24, 07:53
Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:79Replyabsolutely fine! -
Christoph Lehmann wrote 05/16/24, 07:58
Removed cc Christoph Lehmann. -
Garvin Hicking uploaded patch set 6
CR +1V +105/16/24, 08:51apply code review suggestion -
Garvin Hicking commented on patch set 6 05/16/24, 08:52
Important-98484-ExtensionsOutsideOfDocumentRootForComposer-basedTYPO3Installations.rst:60ReplyI replaced this with "create". The superfluous colon was adressed in a prior patch already, which isn't reflected in this gerrit comment here (due to it being releated to patchset 2) - should be good now? -
core-ci voted on patch set 6 V +1 05/16/24, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57824
-
Chris Müller commented on patch set 6 CR +1 V +1 05/16/24, 09:11
👍 -
André Buchmann voted on patch set 6 CR +1 V +1 05/16/24, 09:13
-
Stefan Bürk voted on patch set 6 CR +2 V +2 05/16/24, 09:54
-
Nikita Hovratov voted on patch set 6 CR +1 V +1 05/16/24, 11:11
-
Stefan Bürk merged patch set 7 05/16/24, 11:54