Review main Merged

84283[TASK] Add some `ThumbnailViewHelper` functional tests

Stefan Bürk CR +2 V +2 Normal +93 −0 updated 05/22/24, 11:45

Commit message

This change adds some tests for the `EXT:backend`
ThumbnailViewHelper, mainly to cover fix #102571.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 912

  1. Stefan Bürk uploaded patch set 1 05/15/24, 15:53

  2. Stefan Bürk uploaded patch set 2 05/15/24, 15:55

  3. core-ci voted on patch set 1 V -1 05/15/24, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57778

  4. core-ci voted on patch set 2 V +1 05/15/24, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57779

  5. Oliver Klee voted on patch set 2 V +1 05/15/24, 16:31

  6. Stefan Bürk commented on patch set 2 CR -1 05/21/24, 13:00

    Going to split the dataprovier into dedicated tests ...
  7. Stefan Bürk uploaded patch set 3 CR -1 V +1 05/22/24, 08:16

  8. core-ci voted on patch set 3 V +1 05/22/24, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58040

  9. Stefan Bürk commented on patch set 3 05/22/24, 08:23

    Reply

    Done
  10. Christian Kuhn voted on patch set 3 CR +1 V +1 05/22/24, 09:56

  11. Anja Leichsenring voted on patch set 3 CR +2 V +2 05/22/24, 11:45

  12. Anja Leichsenring merged patch set 4 05/22/24, 11:45