84283[TASK] Add some `ThumbnailViewHelper` functional tests
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 3
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Fixtures/ThumbnailViewHelper/Folders/fileadmin/user_upload/ThumnailViewHelperFalTest.jpgnewbinary
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Fixtures/ThumbnailViewHelper/fal_image.csvnew+32 −0
- typo3/sysext/backend/Tests/Functional/ViewHelpers/ThumbnailViewHelperTest.phpnew+61 −0
Review log 912
-
Stefan Bürk uploaded patch set 1 05/15/24, 15:53
-
Stefan Bürk uploaded patch set 2 05/15/24, 15:55
-
core-ci voted on patch set 1 V -1 05/15/24, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57778
-
core-ci voted on patch set 2 V +1 05/15/24, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57779
-
Oliver Klee voted on patch set 2 V +1 05/15/24, 16:31
-
Stefan Bürk commented on patch set 2 CR -1 05/21/24, 13:00
Going to split the dataprovier into dedicated tests ... -
Stefan Bürk uploaded patch set 3
CR -1V +105/22/24, 08:16 -
core-ci voted on patch set 3 V +1 05/22/24, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58040
-
Stefan Bürk commented on patch set 3 05/22/24, 08:23
Reply
Done -
Christian Kuhn voted on patch set 3 CR +1 V +1 05/22/24, 09:56
-
Anja Leichsenring voted on patch set 3 CR +2 V +2 05/22/24, 11:45
-
Anja Leichsenring merged patch set 4 05/22/24, 11:45