Review main Merged

84284[TASK] Update friendsofphp/php-cs-fixer to 3.57.1

Wouter Wolters CR +2 V +2 Hard +651 −12 updated 05/17/24, 11:34

Commit message

Use parallel runner to use more than 1 CPU.

composer require --dev friendsofphp/php-cs-fixer:^3.57.1

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1519

  1. Wouter Wolters uploaded patch set 1 05/15/24, 21:16

  2. core-ci voted on patch set 1 V +1 05/15/24, 21:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57790

  3. core-ci commented on patch set 1 05/16/24, 06:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57820

  4. Stefan Bürk commented on patch set 1 05/16/24, 07:25

    Note: change to `main` when finishing the change / adding issue.
  5. Oliver Klee commented on patch set 1 05/16/24, 09:15

    composer.json:111

    In the meantime, version 3.57.1 with a fix for an issue with parallelization has been released: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases/tag/v3.57.1 I propose we directly use that version.
  6. Wouter Wolters uploaded patch set 2 V +1 05/16/24, 16:45

  7. Oliver Klee commented on patch set 2 05/16/24, 16:45

    composer.json:111 Reply

    Done
  8. Oliver Klee commented on patch set 2 CR +1 V +1 05/16/24, 16:46

    Reply

    Done
  9. Oliver Klee commented on patch set 2 05/16/24, 16:47

    Would it make sense to backport this to 12.4 and 11.5 as well to make use of the performance benefits?
  10. core-ci voted on patch set 2 V +1 05/16/24, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57832

  11. Torben Hansen voted on patch set 2 CR +1 V +1 05/16/24, 17:41

  12. Andreas Kienast commented on patch set 2 05/17/24, 06:00

    Reply

    I also think having this at least in 12.4 is a must.
  13. Oliver Klee updated the commit message in patch set 3 CR +1 V +1 05/17/24, 09:02

  14. Oliver Klee commented on patch set 3 CR +1 V +1 05/17/24, 09:03

    Reply

    Done
  15. core-ci voted on patch set 3 V +1 05/17/24, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57857

  16. Andreas Kienast voted on patch set 3 CR +1 V +1 05/17/24, 11:02

  17. Georg Ringer voted on patch set 3 CR +1 V +1 05/17/24, 11:03

  18. Andreas Kienast voted on patch set 3 CR +2 V +2 05/17/24, 11:12

  19. Andreas Kienast merged patch set 4 05/17/24, 11:34