Review main Merged

84291[BUGFIX] Allow to modify skipGroupAccessCheck in new PSR-14 event

Benni Mack CR +2 V +2 Easy +12 −1 updated 05/18/24, 08:37

Commit message

With TYPO3 v13.0 the new BeforePageIsRetrievedEvent was
added, and the previous hook was removed. This way, it is not
possible to manipulate $disableGroupAccessCheck anymore.

This change re-adds the possibility to modify this flag in
an EventListener.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Rafael Kähm +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Rafael Kähm +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 67

  1. Benni Mack uploaded patch set 1 05/17/24, 12:01

  2. core-ci voted on patch set 1 V +1 05/17/24, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57866

  3. Simon Schaufelberger voted on patch set 1 CR +1 05/17/24, 13:05

  4. Georg Ringer voted on patch set 1 CR +1 V +1 05/17/24, 19:54

  5. Rafael Kähm voted on patch set 1 CR +1 V +1 05/18/24, 05:42

  6. Benni Mack voted on patch set 1 CR +2 V +2 05/18/24, 08:37

  7. Benni Mack merged patch set 2 05/18/24, 08:37