Review main Merged

84316[BUGFIX] Replace emails with special characters

Moritz Ngo CR +2 V +2 Normal +111 −1 updated 03/27/25, 21:57

Commit message

Due to a string mismatch, certain email addresses with
special characters won't get properly replaced by
EmailLinkBuilder::processEmailLink().

See https://www.rfc-editor.org/rfc/rfc5322 - as almost
anything is allowed for the local part of the
email address.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1318

  1. Moritz Ngo uploaded patch set 1 05/20/24, 09:47

  2. Moritz Ngo marked it ready for review 05/20/24, 09:48

  3. core-ci voted on patch set 1 V +1 05/20/24, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57942

  4. Benni Mack updated the commit message in patch set 2 V +1 10/18/24, 13:30

  5. core-ci voted on patch set 2 V -1 10/18/24, 21:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67978

  6. Benni Mack rebased onto patch set 3 V -1 03/26/25, 21:30

  7. core-ci voted on patch set 3 V +1 03/26/25, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76405

  8. Simon Schaufelberger commented on patch set 3 03/27/25, 01:09

    Can you add a test for this case please?
  9. Georg Ringer commented on patch set 3 03/27/25, 05:08

    Reply

    yes, just wanted 1st to rebase, just to have an idea if it breaks already something in the CI
  10. Benni Mack uploaded patch set 4 V +1 03/27/25, 21:19

  11. Benni Mack commented on patch set 3 CR +1 V +1 03/27/25, 21:19

    Reply

    Done
  12. Benni Mack voted on patch set 4 CR +1 V +1 03/27/25, 21:21

  13. core-ci voted on patch set 4 V -1 03/27/25, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76515

  14. Benni Mack uploaded patch set 5 CR +1 V +1 03/27/25, 21:35

  15. Benni Mack voted on patch set 5 CR +1 V +1 03/27/25, 21:43

  16. core-ci voted on patch set 5 V +1 03/27/25, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76521

  17. Georg Ringer voted on patch set 5 CR +2 V +2 03/27/25, 21:57

  18. Georg Ringer merged patch set 6 03/27/25, 21:57