Review main Merged

84333[BUGFIX] Avoid throwing away previous errors in integrity checks

Stefan Bürk CR +2 V +2 Easy +0 −1 updated 05/21/24, 12:45

Commit message

With change #103465 a couple of code integrity checks based on the
`nikic/php-parser` have been combined into one file scanning script.

The goal is to collect the information per visitor type over all
files in a internal visitor state, to output per visitor result
after all php file have been scanned. However, the visitor message
state is reset for each file with the call of `startProcessing()`
method within `AbstractPhpIntegrityChecker`, thus keeping only the
result of the last error.

This change removes the message reset from the the `startProcessing()`
method to keep all error, thus displaying all errors in one go.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1