84335[BUGFIX] Do not override array finisher options with empty values
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Daniel Goerz +1
-
Verified V +2 Done
- Christian Kuhn +2
- Daniel Goerz +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2130
Show 35 earlier messages
-
Thorben Nissen uploaded patch set 1 05/21/24, 10:32
-
core-ci voted on patch set 1 V -1 05/21/24, 10:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57989
-
Thorben Nissen uploaded patch set 2
V -105/21/24, 10:40 -
core-ci voted on patch set 2 V +1 05/21/24, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57991
-
Stefan Bürk commented on patch set 2 05/21/24, 11:24
-
Thorben Nissen commented on patch set 2 05/21/24, 11:33
I guess, that would work too. The question is, what is faster and/or better? My guess is, one `empty()` call is faster than what you're proposing. The result should be the same, as both an empty string and zero (both as number and string) are treated as empty and are not an array and an empty array is also empty. -
Oliver Klee commented on patch set 2 05/21/24, 13:37
Reply
I'd favor readability/communicative code over performance micro-optimization here, e.g., I'd favor the more expressive variant that @stefan@buerk.tech suggested. Also, empty() behaves in mysterious ways (i.e., it has strange false positives) that tend to fall through the cracks and cause subtle and hard-to find bugs. -
Thorben Nissen uploaded patch set 3
V +105/22/24, 10:53 -
Thorben Nissen commented on patch set 3 05/22/24, 10:54
Reply
AcknowledgedI agree. Changed the code accordingly.FinisherOptionsFlexFormOverridesConverter.php:73ReplyAcknowledged -
core-ci voted on patch set 3 V -1 05/22/24, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58047
-
Thorben Nissen uploaded patch set 4
V -105/22/24, 11:01 -
core-ci voted on patch set 4 V +1 05/22/24, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58048
-
Oliver Klee voted on patch set 4 CR +1 05/22/24, 11:29
-
Benni Mack updated the commit message in patch set 5
CR +1V +110/18/24, 13:31 -
core-ci voted on patch set 5 V -1 10/18/24, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67982
-
Daniel Goerz updated the commit message in patch set 6
V -111/26/24, 11:04 -
Daniel Goerz commented on patch set 6 CR +1 V +1 11/26/24, 11:04
Can we have this in v12 as well, please? -
Oliver Klee wrote 11/26/24, 11:08
Removed reviewer Oliver Klee. -
core-ci voted on patch set 6 V -1 11/26/24, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70199
-
Daniel Goerz rebased onto patch set 7
CR +1V +111/26/24, 11:39 -
core-ci voted on patch set 7 V +1 11/26/24, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70200
-
Daniel Goerz voted on patch set 7 CR +1 V +1 11/26/24, 11:49
-
Christian Kuhn updated the commit message in patch set 8
CR +1V +111/26/24, 16:00 -
Christian Kuhn rebased onto patch set 9 11/26/24, 16:00
-
core-ci voted on patch set 8 V +1 11/26/24, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70211
-
Christian Kuhn rebased onto patch set 10 11/26/24, 16:13
-
core-ci voted on patch set 10 V +1 11/26/24, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70214
-
Daniel Goerz voted on patch set 10 CR +1 V +1 11/28/24, 11:05
-
Christian Kuhn voted on patch set 10 CR +2 V +2 11/28/24, 12:09
-
Christian Kuhn merged patch set 11 11/28/24, 12:09
FinisherOptionsFlexFormOverridesConverter.php:73