Review main Merged

84335[BUGFIX] Do not override array finisher options with empty values

Thorben Nissen CR +2 V +2 Easy +7 −4 updated 11/28/24, 12:09

Commit message

Stop processing of array type finisher options, e.g. recipients, if
the flex form value is empty.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2130

Show 35 earlier messages
  1. Thorben Nissen uploaded patch set 1 05/21/24, 10:32

  2. core-ci voted on patch set 1 V -1 05/21/24, 10:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57989

  3. Thorben Nissen uploaded patch set 2 V -1 05/21/24, 10:40

  4. core-ci voted on patch set 2 V +1 05/21/24, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57991

  5. Stefan Bürk commented on patch set 2 05/21/24, 11:24

    FinisherOptionsFlexFormOverridesConverter.php:73

    Do we really need `empty()` here ? should this not be more a ```php if (!is_array($value) || $value === []) { return; } ``` What do you think ?
  1. Thorben Nissen commented on patch set 2 05/21/24, 11:33

    I guess, that would work too. The question is, what is faster and/or better? My guess is, one `empty()` call is faster than what you're proposing. The result should be the same, as both an empty string and zero (both as number and string) are treated as empty and are not an array and an empty array is also empty.
  2. Oliver Klee commented on patch set 2 05/21/24, 13:37

    Reply

    I'd favor readability/communicative code over performance micro-optimization here, e.g., I'd favor the more expressive variant that @stefan@buerk.tech suggested. Also, empty() behaves in mysterious ways (i.e., it has strange false positives) that tend to fall through the cracks and cause subtle and hard-to find bugs.
  3. Thorben Nissen uploaded patch set 3 V +1 05/22/24, 10:53

  4. Thorben Nissen commented on patch set 3 05/22/24, 10:54

    Reply

    Acknowledged
    I agree. Changed the code accordingly.

    FinisherOptionsFlexFormOverridesConverter.php:73 Reply

    Acknowledged
  5. core-ci voted on patch set 3 V -1 05/22/24, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58047

  6. Thorben Nissen uploaded patch set 4 V -1 05/22/24, 11:01

  7. core-ci voted on patch set 4 V +1 05/22/24, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58048

  8. Oliver Klee voted on patch set 4 CR +1 05/22/24, 11:29

  9. Benni Mack updated the commit message in patch set 5 CR +1 V +1 10/18/24, 13:31

  10. core-ci voted on patch set 5 V -1 10/18/24, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67982

  11. Daniel Goerz updated the commit message in patch set 6 V -1 11/26/24, 11:04

  12. Daniel Goerz commented on patch set 6 CR +1 V +1 11/26/24, 11:04

    Can we have this in v12 as well, please?
  13. Oliver Klee wrote 11/26/24, 11:08

    Removed reviewer Oliver Klee.
  14. core-ci voted on patch set 6 V -1 11/26/24, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70199

  15. Daniel Goerz rebased onto patch set 7 CR +1 V +1 11/26/24, 11:39

  16. core-ci voted on patch set 7 V +1 11/26/24, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70200

  17. Daniel Goerz voted on patch set 7 CR +1 V +1 11/26/24, 11:49

  18. Christian Kuhn updated the commit message in patch set 8 CR +1 V +1 11/26/24, 16:00

  19. Christian Kuhn rebased onto patch set 9 11/26/24, 16:00

  20. core-ci voted on patch set 8 V +1 11/26/24, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70211

  21. Christian Kuhn rebased onto patch set 10 11/26/24, 16:13

  22. core-ci voted on patch set 10 V +1 11/26/24, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70214

  23. Daniel Goerz voted on patch set 10 CR +1 V +1 11/28/24, 11:05

  24. Christian Kuhn voted on patch set 10 CR +2 V +2 11/28/24, 12:09

  25. Christian Kuhn merged patch set 11 11/28/24, 12:09