Review main Merged

84337[BUGFIX] Handle processed file paths properly

Mogens Fiebrandt CR +2 V +2 Easy +3 −1 updated 06/19/24, 17:07

Commit message

When implementing a custom ImageViewHelper to manipulate the image
with the GifBuilder, after processing instructions has been applied,
the processed image in the typo3temp/assets/images folder was a
1x1px sized image.
This happened because the ContentObjectRenderer::getImgResource()
returned null instead of an ImageResource, when the path of a processed
file was passed as $file argument.

It turned out, that the return of
ResourceFactory::retrieveFileOrFolderObject() also can be an instance of
ProcessedFile. So that the @return annotation had to be expanded by this
class.

The change in ContentObjectRenderer::getImgResource() now handles paths
of processed files properly.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1016

  1. Mogens Fiebrandt uploaded patch set 1 05/22/24, 01:39

  2. core-ci voted on patch set 1 V -1 05/22/24, 01:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58011

  3. Mogens Fiebrandt commented on patch set 2 V -1 05/22/24, 01:50

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V -1 05/22/24, 01:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58012

  5. Mogens Fiebrandt commented on patch set 3 V -1 05/22/24, 02:24

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V -1 05/22/24, 02:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58014

  7. Mogens Fiebrandt uploaded patch set 4 V -1 05/22/24, 02:44

  8. core-ci voted on patch set 4 V +1 05/22/24, 02:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58016

  9. Mogens Fiebrandt updated the commit message in patch set 5 V +1 05/22/24, 11:57

  10. core-ci voted on patch set 5 V +1 05/22/24, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58052

  11. Stefan Bürk commented on patch set 5 CR -1 05/24/24, 09:04

    on it ...
  12. Mogens Fiebrandt rebased onto patch set 6 CR -1 V +1 06/19/24, 12:20

  13. core-ci voted on patch set 6 V +1 06/19/24, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59847

  14. Benni Mack voted on patch set 6 CR +1 V +1 06/19/24, 12:26

  15. Stefan Bürk commented on patch set 6 CR +2 V +2 06/19/24, 17:07

    Reply

    Done
  16. Stefan Bürk merged patch set 7 06/19/24, 17:07