84339[BUGFIX] Guard array key access in `SetupModuleController`
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1620
-
Ziad Abdul Hai uploaded patch set 1 05/22/24, 05:48
-
Andreas Kienast voted on patch set 1 CR +1 05/22/24, 05:53
-
core-ci voted on patch set 1 V +1 05/22/24, 05:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58033
-
Garvin Hicking commented on patch set 1 05/22/24, 05:56
-
Andreas Kienast commented on patch set 1 05/22/24, 05:59
SetupModuleController.php:299ReplyThat's not true. The method `setAvatarFileUid()` checks for an "empty" `$fileUid` and aborts then. -
Stefan Bürk updated the commit message in patch set 2
CR +1V +105/22/24, 06:05 -
Garvin Hicking commented on patch set 2 CR +1 05/22/24, 06:06
SetupModuleController.php:299ReplyAh, thanks, didn't check the code contained there, sorry for the noise. -
core-ci voted on patch set 2 V +1 05/22/24, 06:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58035
-
Willi Wehmeier voted on patch set 2 CR +1 05/22/24, 06:14
-
Andreas Kienast voted on patch set 2 CR +1 05/22/24, 06:15
-
Andreas Kienast voted on patch set 2 V +1 05/22/24, 06:47
-
Stefan Bürk commented on patch set 2 05/22/24, 07:37
SetupModuleController.php:299I would prefere here to use `?? null` as fallback to emphasize the "not given" state more and additionally change the annotatin method `setAvatarFileUid` that nullable file uid is possible (and in place for later making it native typed).SetupModuleController.php:839I would add ``` * @param int|null $fileUid ``` to the method docblock with some description for that parameter -
Georg Ringer commented on patch set 3
CR +1V +105/29/24, 04:55Published edit on patch set 2. -
core-ci voted on patch set 3 V -1 05/29/24, 05:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58433
-
Georg Ringer commented on patch set 4
V -105/30/24, 06:34Published edit on patch set 3. -
core-ci voted on patch set 4 V +1 05/30/24, 06:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58474
-
Christian Kuhn commented on patch set 4 CR +1 V +1 06/05/24, 14:40
SetupModuleController.php:299ReplyDoneSetupModuleController.php:839ReplyDone -
Stefan Bürk voted on patch set 4 CR +1 V +1 06/05/24, 14:43
-
Christian Kuhn voted on patch set 4 CR +2 V +2 06/05/24, 15:10
-
Christian Kuhn merged patch set 5 06/05/24, 15:10
SetupModuleController.php:299