84342[FEATURE] Introduce Site Settings Editor
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 66
- Build/Scripts/checkIntegritySetLabels.php+5 −1
- Build/Sources/Sass/component/_settings.scssnew+264 −0
- Build/Sources/Sass/backend.scss+1 −0
- Build/Sources/TypeScript/backend/settings/editor/editable-setting.ts2new+197 −0
- Build/Sources/TypeScript/backend/settings/type/base.tsnew+194 −0
- Build/Sources/TypeScript/backend/settings/type/bool.tsnew+55 −0
- Build/Sources/TypeScript/backend/settings/type/color.tsnew+63 −0
- Build/Sources/TypeScript/backend/settings/type/int.tsnew+42 −0
- Build/Sources/TypeScript/backend/settings/type/number.tsnew+43 −0
- Build/Sources/TypeScript/backend/settings/type/string.tsnew+42 −0
- Build/Sources/TypeScript/backend/settings/type/stringlist.tsnew+86 −0
- Build/Sources/TypeScript/backend/settings/editor.ts4new+210 −0
- Build/Sources/TypeScript/backend/copy-to-clipboard.ts+33 −24
- Build/tests/playwright/accessibility/modules.spec.ts+4 −0
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+26 −6
- typo3/sysext/backend/Classes/Controller/SiteSettingsController.phpnew+326 −0
- typo3/sysext/backend/Classes/Dto/Settings/EditableSetting.phpnew+38 −0
- typo3/sysext/backend/Configuration/Backend/Modules.php2+26 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_siteconfiguration.xlf+9 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_sitesettings.xlfnew+53 −0
Show 46 more files
- typo3/sysext/backend/Resources/Private/Language/locallang_sitesettings_module.xlf3new+17 −0
- typo3/sysext/backend/Resources/Private/Templates/SiteConfiguration/Overview.html+25 −0
- typo3/sysext/backend/Resources/Private/Templates/SiteSettings/Edit.htmlnew+35 −0
- typo3/sysext/backend/Resources/Private/Templates/SiteSettings/Overview.htmlnew+54 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+58 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/editor/editable-setting.jsnew+69 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/base.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/bool.jsnew+24 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/color.jsnew+21 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/int.jsnew+21 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/number.jsnew+22 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/string.jsnew+21 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/stringlist.jsnew+45 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/editor.jsnew+62 −0
- typo3/sysext/backend/Resources/Public/JavaScript/copy-to-clipboard.js+1 −1
- typo3/sysext/core/Classes/Configuration/SiteWriter.php+9 −1
- typo3/sysext/core/Classes/Settings/Type/BoolType.php+5 −0
- typo3/sysext/core/Classes/Settings/Type/ColorType.php+5 −0
- typo3/sysext/core/Classes/Settings/Type/IntType.php+5 −0
- typo3/sysext/core/Classes/Settings/Type/NumberType.php+5 −0
- typo3/sysext/core/Classes/Settings/Type/StringListType.php+14 −0
- typo3/sysext/core/Classes/Settings/Type/StringType.php+5 −0
- typo3/sysext/core/Classes/Settings/Category.phpnew+43 −0
- typo3/sysext/core/Classes/Settings/CategoryAccumulator.phpnew+93 −0
- typo3/sysext/core/Classes/Settings/CategoryDefinition.phpnew+42 −0
- typo3/sysext/core/Classes/Settings/SettingDefinition.php+1 −1
- typo3/sysext/core/Classes/Settings/SettingsTypeInterface.php+2 −0
- typo3/sysext/core/Classes/Site/Entity/Site.php+12 −0
- typo3/sysext/core/Classes/Site/Set/CategoryRegistry.phpnew+59 −0
- typo3/sysext/core/Classes/Site/Set/SetDefinition.php+3 −0
- typo3/sysext/core/Classes/Site/Set/YamlSetDefinitionProvider.php+19 −1
- typo3/sysext/core/Classes/Site/SiteSettingsFactory.php+25 −0
- typo3/sysext/core/Classes/Site/SiteSettingsService.phpnew+180 −0
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-104794-IntroduceSiteSettingsEditor.rst4new+81 −0
- typo3/sysext/felogin/Configuration/Sets/Felogin/labels.xlf+5 −0
- typo3/sysext/felogin/Configuration/Sets/Felogin/settings.definitions.yaml+28 −0
- typo3/sysext/fluid_styled_content/Configuration/Sets/FluidStyledContent/labels.xlf+11 −0
- typo3/sysext/fluid_styled_content/Configuration/Sets/FluidStyledContent/settings.definitions.yaml+31 −0
- typo3/sysext/indexed_search/Configuration/Sets/IndexedSearch/labels.xlf+7 −0
- typo3/sysext/indexed_search/Configuration/Sets/IndexedSearch/settings.definitions.yaml+10 −0
- typo3/sysext/redirects/Configuration/Backend/Modules.php+1 −1
- typo3/sysext/redirects/Configuration/Sets/redirects/config.yamlnew+1 −0
- typo3/sysext/redirects/Configuration/Sets/redirects/labels.xlfnew+39 −0
- typo3/sysext/redirects/Configuration/Sets/redirects/settings.definitions.yamlnew+20 −0
- typo3/sysext/seo/Configuration/Sets/Sitemap/labels.xlf+7 −0
- typo3/sysext/seo/Configuration/Sets/Sitemap/settings.definitions.yaml+11 −0
Review log 60105
Show 4480 earlier messages
-
Benjamin Franzke uploaded patch set 1 05/22/24, 07:26
-
Benjamin Franzke uploaded patch set 2 05/22/24, 07:28
-
core-ci voted on patch set 1 V -1 05/22/24, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58038
-
core-ci voted on patch set 2 V -1 05/22/24, 07:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58039
-
Benjamin Franzke uploaded patch set 3
V -105/24/24, 09:15 -
core-ci voted on patch set 3 V -1 05/24/24, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58143
-
Benjamin Franzke marked it work in progress 05/30/24, 07:15
-
Benjamin Franzke uploaded patch set 4
V -107/05/24, 09:24 -
core-ci voted on patch set 4 V -1 07/05/24, 09:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61029
-
Benjamin Franzke wrote 07/05/24, 09:40
Removed cc Benjamin Kott. -
Benjamin Franzke uploaded patch set 5
V -107/09/24, 07:31 -
core-ci voted on patch set 5 V -1 07/09/24, 07:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61214
-
Benjamin Franzke uploaded patch set 6
V -107/09/24, 12:35 -
core-ci voted on patch set 6 V +1 07/09/24, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61234
-
Benjamin Franzke uploaded patch set 7
V +107/09/24, 13:18 -
core-ci voted on patch set 7 V +1 07/09/24, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61236
-
Benjamin Franzke uploaded patch set 8
V +108/08/24, 09:07 -
core-ci voted on patch set 8 V +1 08/08/24, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63034
-
Benjamin Franzke uploaded patch set 9
V +108/16/24, 08:52 -
core-ci voted on patch set 9 V -1 08/16/24, 09:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63565
-
Benjamin Franzke uploaded patch set 10
V -108/19/24, 13:25 -
core-ci voted on patch set 10 V -1 08/19/24, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63775
-
Benjamin Franzke uploaded patch set 11
V -108/19/24, 16:39 -
core-ci voted on patch set 11 V +1 08/19/24, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63780
-
Benjamin Franzke uploaded patch set 12
V +108/20/24, 12:53 -
core-ci voted on patch set 12 V +1 08/20/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63832
-
Benjamin Franzke uploaded patch set 13
V +108/27/24, 15:22 -
core-ci voted on patch set 13 V -1 08/27/24, 15:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64331
-
Benjamin Franzke uploaded patch set 14
V -108/27/24, 15:31 -
core-ci voted on patch set 14 V +1 08/27/24, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64333
-
Benjamin Franzke uploaded patch set 15
V +108/29/24, 08:56 -
core-ci voted on patch set 15 V +1 08/29/24, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64462
-
Benjamin Franzke uploaded patch set 16
V +108/29/24, 11:25 -
core-ci voted on patch set 16 V -1 08/29/24, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64468
-
core-ci voted on patch set 16 V +1 08/29/24, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64468
-
Benjamin Franzke uploaded patch set 17
V +109/02/24, 11:44 -
core-ci voted on patch set 17 V +1 09/02/24, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64630
-
Benjamin Franzke uploaded patch set 18
V +109/03/24, 09:37 -
core-ci voted on patch set 18 V +1 09/03/24, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64656
-
Benni Mack commented on patch set 18 09/03/24, 14:21
SettingsInterface.php:23please check if we must extend (= inheritance) or can just add the array access on the implementations -
Michael Schams commented on patch set 18 09/04/24, 04:14
locallang_sitesettings_module.xlf:7The label "Settings" is also used for the settings category under Admin Tools. This might be confusing. How about a differentiation: "Site Settings" and "System Settings". -
Benjamin Franzke uploaded patch set 19
V +109/04/24, 09:07 -
Benjamin Franzke commented on patch set 19 09/04/24, 09:08
SettingsInterface.php:23ReplyPorted the rendering to Editor rendering to JavaScript, so I could drop this (which added for fluid access). -
core-ci voted on patch set 19 V -1 09/04/24, 09:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64730
-
Benjamin Franzke uploaded patch set 20
V -109/04/24, 09:45 -
Benjamin Franzke commented on patch set 20 09/04/24, 09:45
locallang_sitesettings_module.xlf:7ReplyThanks for bringing this up. Currently we'd favor "Settings" instead of "Site Settings", as this module is categorized under "Site Management". The "problem" with the other settings module is that it is actually misplaced under AdminTools and would better be placed in the `System` category. I'll keep this open for now… (maybe we should improve the nmodule avigation styling to, if the categorization can not be properly recognized) -
core-ci voted on patch set 20 V +1 09/04/24, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64738
-
Benjamin Franzke uploaded patch set 21
V +109/04/24, 09:55 -
core-ci voted on patch set 21 V +1 09/04/24, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64742
-
Benjamin Franzke uploaded patch set 22
V +109/04/24, 12:54 -
core-ci voted on patch set 22 V +1 09/04/24, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64754
-
Benjamin Franzke uploaded patch set 23
V +109/05/24, 10:28 -
core-ci voted on patch set 23 V +1 09/05/24, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64853
-
Benjamin Franzke uploaded patch set 24
V +109/06/24, 11:38 -
core-ci voted on patch set 24 V +1 09/06/24, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64948
-
Benjamin Franzke uploaded patch set 25
V +109/09/24, 03:48 -
core-ci voted on patch set 25 V +1 09/09/24, 03:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65049
-
Benjamin Franzke uploaded patch set 26
V +109/09/24, 10:12 -
core-ci voted on patch set 26 V +1 09/09/24, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65079
-
Benjamin Franzke uploaded patch set 27
V +109/09/24, 10:22 -
core-ci voted on patch set 27 V +1 09/09/24, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65081
-
Benjamin Franzke uploaded patch set 28
V +109/09/24, 12:48 -
core-ci voted on patch set 28 V +1 09/09/24, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65088
-
Benjamin Franzke uploaded patch set 29
V +109/10/24, 09:42 -
core-ci voted on patch set 29 V -1 09/10/24, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65203
-
Benjamin Franzke uploaded patch set 30
V -109/10/24, 09:56 -
core-ci voted on patch set 30 V -1 09/10/24, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65205
-
Benjamin Franzke uploaded patch set 31
V -109/10/24, 10:27 -
core-ci voted on patch set 31 V -1 09/10/24, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65215
-
Benjamin Franzke uploaded patch set 32
V -109/10/24, 11:33 -
core-ci voted on patch set 32 V +1 09/10/24, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65219
-
Benjamin Franzke uploaded patch set 33
V +109/10/24, 12:20 -
core-ci voted on patch set 33 V +1 09/10/24, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65235
-
Benjamin Franzke uploaded patch set 34
V +109/10/24, 13:39 -
core-ci voted on patch set 34 V +1 09/10/24, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65254
-
Benjamin Franzke uploaded patch set 35
V +109/10/24, 14:52 -
core-ci voted on patch set 35 V +1 09/10/24, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65267
-
Benni Mack commented on patch set 35 09/10/24, 15:05
editor.ts:133what happens on level5? do we catch this at some point?editor.ts:157what happens to <h6> ?editable-setting.ts:179what about NProgress here, do we want to keep it? Otherwise, just remove the commentModules.php:80for later: We need to discuss on how to make this available for "integrators" that might be non-admins. -
Benjamin Franzke uploaded patch set 36
V +109/10/24, 16:31 -
Benjamin Franzke commented on patch set 36 09/10/24, 16:31
editor.ts:133ReplyNo, we just render what the server desires. But I'll normalize to h6-max.editor.ts:157Replyaddededitable-setting.ts:179ReplyDoneModules.php:80Replyack
-
Benjamin Franzke uploaded patch set 37 09/10/24, 16:36
-
Benjamin Franzke commented on patch set 37 09/10/24, 16:36
locallang_sitesettings_module.xlf:7ReplyWill use `Settings` for now. -
core-ci voted on patch set 36 V +1 09/10/24, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65285
-
core-ci voted on patch set 37 V +1 09/10/24, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65287
-
Benjamin Franzke uploaded patch set 38
V +109/10/24, 17:58 -
core-ci voted on patch set 38 V +1 09/10/24, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65309
-
Garvin Hicking commented on patch set 39
V +109/10/24, 18:15Published edit on patch set 38. -
Garvin Hicking updated the commit message in patch set 40 09/10/24, 18:15
-
core-ci voted on patch set 40 V +1 09/10/24, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65315
-
core-ci voted on patch set 39 V +1 09/10/24, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65314
-
Benni Mack commented on patch set 40 09/10/24, 19:04
Feature-104794-IntroduceSiteSettingsEditor.rst:25minimal diff => "minimal difference"Feature-104794-IntroduceSiteSettingsEditor.rst:74Site-scoped settings will most likely be the place to configure site-wide configuration, which was previously only possible to modify via Constant Editor, modifying TypoScript constants. It is recommended to use site-sets and their UI configuration in favor of Typoscript Constants in the future. -
Benjamin Franzke uploaded patch set 41
V +109/10/24, 19:49 -
core-ci voted on patch set 41 V +1 09/10/24, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65328
-
Benjamin Franzke uploaded patch set 42
V +109/10/24, 20:08 -
Benjamin Franzke commented on patch set 42 09/10/24, 20:08
Feature-104794-IntroduceSiteSettingsEditor.rst:25ReplyDoneFeature-104794-IntroduceSiteSettingsEditor.rst:74ReplyDone -
core-ci voted on patch set 42 V +1 09/10/24, 20:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65339
-
Benjamin Franzke uploaded patch set 43
V +109/10/24, 20:28 -
Benjamin Kott voted on patch set 43 CR +1 V +1 09/10/24, 20:32
-
Benjamin Franzke uploaded patch set 44
CR +1V +109/10/24, 20:40 -
core-ci voted on patch set 43 V -1 09/10/24, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65345
-
core-ci voted on patch set 44 V +1 09/10/24, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65351
-
Benni Mack voted on patch set 44 CR +1 V +1 09/10/24, 20:54
-
Benjamin Kott voted on patch set 44 CR +1 V +1 09/10/24, 20:54
-
Benjamin Franzke voted on patch set 44 CR +2 V +2 09/10/24, 20:55
-
Benjamin Franzke merged patch set 45 09/10/24, 20:55