Review main Merged

84342[FEATURE] Introduce Site Settings Editor

Benjamin Franzke CR +2 V +2 Nightmare +2984 −36 updated 09/10/24, 20:55

Commit message

A new Site Settings editor has been introduced that allows to configure
per-site settings in `config/sites/*/settings.yaml`.

The new backend module `Site Management > Settings` provides an overview
of sites which offer configurable settings and makes them editable based
on Site Set provided Settings Definitions.

The editor shows a list of settings categories and respective settings.
It will persist all settings into `config/sites/*/settings.yaml`.
The module will only persist settings that deviate from the site-scoped
default value. That means it will only change the minimal difference to
the settings set defined by the active sets for the respective site.

The backend module is currently available for administrators only, but
will likely be extended to be made available for editors in future.

Anonymous (undefined) site settings – as supported since TYPO3 v10 –
will not be made editable, but will be preserved as-is when persisting
changes through the settings editor.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 66

Show 46 more files

Review log 60105

Show 4480 earlier messages
  1. Benjamin Franzke uploaded patch set 1 05/22/24, 07:26

  2. Benjamin Franzke uploaded patch set 2 05/22/24, 07:28

  3. core-ci voted on patch set 1 V -1 05/22/24, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58038

  4. core-ci voted on patch set 2 V -1 05/22/24, 07:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58039

  5. Benjamin Franzke uploaded patch set 3 V -1 05/24/24, 09:15

  6. core-ci voted on patch set 3 V -1 05/24/24, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58143

  7. Benjamin Franzke marked it work in progress 05/30/24, 07:15

  8. Benjamin Franzke uploaded patch set 4 V -1 07/05/24, 09:24

  9. core-ci voted on patch set 4 V -1 07/05/24, 09:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61029

  10. Benjamin Franzke wrote 07/05/24, 09:40

    Removed cc Benjamin Kott.
  11. Benjamin Franzke uploaded patch set 5 V -1 07/09/24, 07:31

  12. core-ci voted on patch set 5 V -1 07/09/24, 07:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61214

  13. Benjamin Franzke uploaded patch set 6 V -1 07/09/24, 12:35

  14. core-ci voted on patch set 6 V +1 07/09/24, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61234

  15. Benjamin Franzke uploaded patch set 7 V +1 07/09/24, 13:18

  16. core-ci voted on patch set 7 V +1 07/09/24, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61236

  17. Benjamin Franzke uploaded patch set 8 V +1 08/08/24, 09:07

  18. core-ci voted on patch set 8 V +1 08/08/24, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63034

  19. Benjamin Franzke uploaded patch set 9 V +1 08/16/24, 08:52

  20. core-ci voted on patch set 9 V -1 08/16/24, 09:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63565

  21. Benjamin Franzke uploaded patch set 10 V -1 08/19/24, 13:25

  22. core-ci voted on patch set 10 V -1 08/19/24, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63775

  23. Benjamin Franzke uploaded patch set 11 V -1 08/19/24, 16:39

  24. core-ci voted on patch set 11 V +1 08/19/24, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63780

  25. Benjamin Franzke uploaded patch set 12 V +1 08/20/24, 12:53

  26. core-ci voted on patch set 12 V +1 08/20/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63832

  27. Benjamin Franzke uploaded patch set 13 V +1 08/27/24, 15:22

  28. core-ci voted on patch set 13 V -1 08/27/24, 15:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64331

  29. Benjamin Franzke uploaded patch set 14 V -1 08/27/24, 15:31

  30. core-ci voted on patch set 14 V +1 08/27/24, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64333

  31. Benjamin Franzke uploaded patch set 15 V +1 08/29/24, 08:56

  32. core-ci voted on patch set 15 V +1 08/29/24, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64462

  33. Benjamin Franzke uploaded patch set 16 V +1 08/29/24, 11:25

  34. core-ci voted on patch set 16 V -1 08/29/24, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64468

  35. core-ci voted on patch set 16 V +1 08/29/24, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64468

  36. Benjamin Franzke uploaded patch set 17 V +1 09/02/24, 11:44

  37. core-ci voted on patch set 17 V +1 09/02/24, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64630

  38. Benjamin Franzke uploaded patch set 18 V +1 09/03/24, 09:37

  39. core-ci voted on patch set 18 V +1 09/03/24, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64656

  40. Benni Mack commented on patch set 18 09/03/24, 14:21

    SettingsInterface.php:23

    please check if we must extend (= inheritance) or can just add the array access on the implementations
  41. Michael Schams commented on patch set 18 09/04/24, 04:14

    locallang_sitesettings_module.xlf:7

    The label "Settings" is also used for the settings category under Admin Tools. This might be confusing. How about a differentiation: "Site Settings" and "System Settings".
  42. Benjamin Franzke uploaded patch set 19 V +1 09/04/24, 09:07

  43. Benjamin Franzke commented on patch set 19 09/04/24, 09:08

    SettingsInterface.php:23 Reply

    Ported the rendering to Editor rendering to JavaScript, so I could drop this (which added for fluid access).
  44. core-ci voted on patch set 19 V -1 09/04/24, 09:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64730

  45. Benjamin Franzke uploaded patch set 20 V -1 09/04/24, 09:45

  46. Benjamin Franzke commented on patch set 20 09/04/24, 09:45

    locallang_sitesettings_module.xlf:7 Reply

    Thanks for bringing this up. Currently we'd favor "Settings" instead of "Site Settings", as this module is categorized under "Site Management". The "problem" with the other settings module is that it is actually misplaced under AdminTools and would better be placed in the `System` category. I'll keep this open for now… (maybe we should improve the nmodule avigation styling to, if the categorization can not be properly recognized)
  47. core-ci voted on patch set 20 V +1 09/04/24, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64738

  48. Benjamin Franzke uploaded patch set 21 V +1 09/04/24, 09:55

  49. core-ci voted on patch set 21 V +1 09/04/24, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64742

  50. Benjamin Franzke uploaded patch set 22 V +1 09/04/24, 12:54

  51. core-ci voted on patch set 22 V +1 09/04/24, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64754

  52. Benjamin Franzke uploaded patch set 23 V +1 09/05/24, 10:28

  53. core-ci voted on patch set 23 V +1 09/05/24, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64853

  54. Benjamin Franzke uploaded patch set 24 V +1 09/06/24, 11:38

  55. core-ci voted on patch set 24 V +1 09/06/24, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64948

  56. Benjamin Franzke uploaded patch set 25 V +1 09/09/24, 03:48

  57. core-ci voted on patch set 25 V +1 09/09/24, 03:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65049

  58. Benjamin Franzke uploaded patch set 26 V +1 09/09/24, 10:12

  59. core-ci voted on patch set 26 V +1 09/09/24, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65079

  60. Benjamin Franzke uploaded patch set 27 V +1 09/09/24, 10:22

  61. core-ci voted on patch set 27 V +1 09/09/24, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65081

  62. Benjamin Franzke uploaded patch set 28 V +1 09/09/24, 12:48

  63. core-ci voted on patch set 28 V +1 09/09/24, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65088

  64. Benjamin Franzke uploaded patch set 29 V +1 09/10/24, 09:42

  65. core-ci voted on patch set 29 V -1 09/10/24, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65203

  66. Benjamin Franzke uploaded patch set 30 V -1 09/10/24, 09:56

  67. core-ci voted on patch set 30 V -1 09/10/24, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65205

  68. Benjamin Franzke uploaded patch set 31 V -1 09/10/24, 10:27

  69. core-ci voted on patch set 31 V -1 09/10/24, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65215

  70. Benjamin Franzke uploaded patch set 32 V -1 09/10/24, 11:33

  71. core-ci voted on patch set 32 V +1 09/10/24, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65219

  72. Benjamin Franzke uploaded patch set 33 V +1 09/10/24, 12:20

  73. core-ci voted on patch set 33 V +1 09/10/24, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65235

  74. Benjamin Franzke uploaded patch set 34 V +1 09/10/24, 13:39

  75. core-ci voted on patch set 34 V +1 09/10/24, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65254

  76. Benjamin Franzke uploaded patch set 35 V +1 09/10/24, 14:52

  77. core-ci voted on patch set 35 V +1 09/10/24, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65267

  78. Benni Mack commented on patch set 35 09/10/24, 15:05

    editor.ts:133

    what happens on level5? do we catch this at some point?

    editor.ts:157

    what happens to <h6> ?

    editable-setting.ts:179

    what about NProgress here, do we want to keep it? Otherwise, just remove the comment

    Modules.php:80

    for later: We need to discuss on how to make this available for "integrators" that might be non-admins.
  79. Benjamin Franzke uploaded patch set 36 V +1 09/10/24, 16:31

  80. Benjamin Franzke commented on patch set 36 09/10/24, 16:31

    editor.ts:133 Reply

    No, we just render what the server desires. But I'll normalize to h6-max.

    editor.ts:157 Reply

    added

    editable-setting.ts:179 Reply

    Done

    Modules.php:80 Reply

    ack
  1. Benjamin Franzke uploaded patch set 37 09/10/24, 16:36

  2. Benjamin Franzke commented on patch set 37 09/10/24, 16:36

    locallang_sitesettings_module.xlf:7 Reply

    Will use `Settings` for now.
  3. core-ci voted on patch set 36 V +1 09/10/24, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65285

  4. core-ci voted on patch set 37 V +1 09/10/24, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65287

  5. Benjamin Franzke uploaded patch set 38 V +1 09/10/24, 17:58

  6. core-ci voted on patch set 38 V +1 09/10/24, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65309

  7. Garvin Hicking commented on patch set 39 V +1 09/10/24, 18:15

    Published edit on patch set 38.
  8. Garvin Hicking updated the commit message in patch set 40 09/10/24, 18:15

  9. core-ci voted on patch set 40 V +1 09/10/24, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65315

  10. core-ci voted on patch set 39 V +1 09/10/24, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65314

  11. Benni Mack commented on patch set 40 09/10/24, 19:04

    Feature-104794-IntroduceSiteSettingsEditor.rst:25

    minimal diff => "minimal difference"

    Feature-104794-IntroduceSiteSettingsEditor.rst:74

    Site-scoped settings will most likely be the place to configure site-wide configuration, which was previously only possible to modify via Constant Editor, modifying TypoScript constants. It is recommended to use site-sets and their UI configuration in favor of Typoscript Constants in the future.
  12. Benjamin Franzke uploaded patch set 41 V +1 09/10/24, 19:49

  13. core-ci voted on patch set 41 V +1 09/10/24, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65328

  14. Benjamin Franzke uploaded patch set 42 V +1 09/10/24, 20:08

  15. Benjamin Franzke commented on patch set 42 09/10/24, 20:08

    Feature-104794-IntroduceSiteSettingsEditor.rst:25 Reply

    Done

    Feature-104794-IntroduceSiteSettingsEditor.rst:74 Reply

    Done
  16. core-ci voted on patch set 42 V +1 09/10/24, 20:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65339

  17. Benjamin Franzke uploaded patch set 43 V +1 09/10/24, 20:28

  18. Benjamin Kott voted on patch set 43 CR +1 V +1 09/10/24, 20:32

  19. Benjamin Franzke uploaded patch set 44 CR +1 V +1 09/10/24, 20:40

  20. core-ci voted on patch set 43 V -1 09/10/24, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65345

  21. core-ci voted on patch set 44 V +1 09/10/24, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65351

  22. Benni Mack voted on patch set 44 CR +1 V +1 09/10/24, 20:54

  23. Benjamin Kott voted on patch set 44 CR +1 V +1 09/10/24, 20:54

  24. Benjamin Franzke voted on patch set 44 CR +2 V +2 09/10/24, 20:55

  25. Benjamin Franzke merged patch set 45 09/10/24, 20:55