84346[BUGFIX] Parse INCLUDE_TYPOSCRIPT conditions that contain ">"
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeFromLineStreamBuilder.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/LosslessTokenizer.php+7 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/LossyTokenizer.php+8 −2
- typo3/sysext/core/Tests/Unit/TypoScript/Tokenizer/TokenizerInterfaceTest.php+61 −1
Review log 1824
-
Florian Rival uploaded patch set 1 05/22/24, 13:04
-
Florian Rival updated the commit message in patch set 2 05/22/24, 13:07
-
Stefan Bürk commented on patch set 2 05/22/24, 13:12
I guess we should cover this with test(s) ... -
Christian Kuhn commented on patch set 2 05/22/24, 13:13
needs a rebase to current main for CI to kick in, this is based on a quite old parent. -
Florian Rival rebased onto patch set 3 05/26/24, 23:21
-
core-ci voted on patch set 3 V +1 05/26/24, 23:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58302
-
Christian Kuhn uploaded patch set 4
V +105/27/24, 16:58 -
Christian Kuhn commented on patch set 4 05/27/24, 16:58
Reply
Done -
core-ci voted on patch set 4 V -1 05/27/24, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58350
-
Christian Kuhn commented on patch set 4 CR -1 05/27/24, 17:40
see my comment on https://forge.typo3.org/issues/103875 for my current headaches. needs a decision on how to continue. -
Christian Kuhn uploaded patch set 5
CR -1V -105/28/24, 08:25 -
core-ci voted on patch set 5 V +1 05/28/24, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58383
-
Christian Kuhn updated the commit message in patch set 6
V +105/28/24, 08:37 -
Christian Kuhn voted on patch set 6 CR +1 V +1 05/28/24, 08:38
-
core-ci voted on patch set 6 V +1 05/28/24, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58384
-
Christian Kuhn uploaded patch set 7
CR +1V +105/28/24, 08:43 -
Christian Kuhn voted on patch set 7 CR +1 V +1 05/28/24, 08:43
-
core-ci voted on patch set 7 V +1 05/28/24, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58385
-
Christian Kuhn uploaded patch set 8
CR +1V +105/28/24, 08:47 -
core-ci voted on patch set 8 V +1 05/28/24, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58386
-
Christian Kuhn voted on patch set 8 CR +1 V +1 05/28/24, 09:03
-
Stefan Bürk voted on patch set 8 CR +1 V +1 05/28/24, 09:54
-
Christian Kuhn voted on patch set 8 CR +2 V +2 05/28/24, 10:56
-
Christian Kuhn merged patch set 9 05/28/24, 10:56