Review main Merged

84349[TASK] Use xxh3 over sha1 in PackageDependentCacheIdentifier

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 05/22/24, 18:18

Commit message

This 64bit hash is quicker and shorter than sha1
and should give enough collision protection for
this use case.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 05/22/24, 15:05

  2. core-ci voted on patch set 1 V +1 05/22/24, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58064

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 05/22/24, 16:30

  4. Oliver Klee voted on patch set 1 CR +1 V +1 05/22/24, 17:07

  5. Georg Ringer voted on patch set 1 CR +2 V +2 05/22/24, 18:18

  6. Georg Ringer merged patch set 2 05/22/24, 18:18