Review main Merged

84374[TASK] Streamline usage of `Persistent.loadFromServer()`

Andreas Kienast CR +2 V +2 Easy +3 −6 updated 05/24/24, 08:21

Commit message

Previously, the internal method `loadFromServer()` from the module
`@typo3/backend/storage/persistent` fetched the data, wrote it into an
internal property `data` and also returned it. The code is now
simplified to only return the response.
Setting `data` is now done within the public `get()` method, which is
now also simplified a bit.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Marvin Buchmann +1
    • Frank Nägler +1
    • Willi Wehmeier +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Andreas Kienast uploaded patch set 1 05/23/24, 13:00

  2. core-ci voted on patch set 1 V +1 05/23/24, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58102

  3. Willi Wehmeier voted on patch set 1 CR +1 05/23/24, 13:27

  4. Marvin Buchmann voted on patch set 1 CR +1 05/23/24, 14:25

  5. Frank Nägler voted on patch set 1 CR +1 05/23/24, 14:29

  6. Frank Nägler voted on patch set 1 V +1 05/23/24, 14:32

  7. Andreas Nedbal voted on patch set 1 CR +1 V +1 05/24/24, 08:16

  8. Andreas Kienast voted on patch set 1 CR +2 V +2 05/24/24, 08:21

  9. Andreas Kienast merged patch set 2 05/24/24, 08:21