84375[BUGFIX] Respect doctype when generating meta tags
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Nikita Hovratov +1
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/core/Classes/MetaTag/AbstractMetaTagManager.php+6 −2
- typo3/sysext/core/Classes/MetaTag/GenericMetaTagManager.php+7 −3
- typo3/sysext/core/Tests/Functional/MetaDataHandling/PluginsTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+14 −14
- typo3/sysext/core/Tests/Unit/MetaTag/GenericMetaTagManagerTest.php+32 −10
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+1 −0
- typo3/sysext/seo/Tests/Functional/MetaTag/MetaTagTest.php+1 −1
- typo3/sysext/seo/Tests/Unit/MetaTag/OpenGraphMetaTagManagerTest.php+21 −10
- typo3/sysext/seo/Tests/Unit/MetaTag/TwitterCardMetaTagManagerTest.php+18 −7
Review log 1013
-
Oli Bartsch uploaded patch set 1 05/23/24, 16:11
-
core-ci voted on patch set 1 V -1 05/23/24, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58107
-
Oli Bartsch uploaded patch set 2
V -105/23/24, 16:29 -
core-ci voted on patch set 2 V -1 05/23/24, 16:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58108
-
Oli Bartsch uploaded patch set 3
V -105/23/24, 17:06 -
core-ci voted on patch set 3 V +1 05/23/24, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58109
-
Benni Mack voted on patch set 3 CR +1 V +1 05/23/24, 21:03
-
Nikita Hovratov voted on patch set 3 CR +1 05/23/24, 21:39
-
Andreas Kienast commented on patch set 3 05/24/24, 06:13
AFAICS we don't have any test now for non-HTML5 scenarios, do we? -
Oli Bartsch commented on patch set 3 05/24/24, 06:48
Reply
I‘ve added checkRenderAllPropertiesUsesCorrectEndingSlash() for this. -
Andreas Kienast commented on patch set 3 CR +1 V +1 05/24/24, 07:09
Reply
Wow, it's so tiny and hidden. Sorry for the noise 😄 -
Oli Bartsch voted on patch set 3 CR +2 V +2 05/24/24, 08:08
-
Oli Bartsch merged patch set 4 05/24/24, 08:09