Review main Merged

84375[BUGFIX] Respect doctype when generating meta tags

Oli Bartsch CR +2 V +2 Normal +102 −49 updated 05/24/24, 08:09

Commit message

The GenericMetaTagManager as well as the abstract
class (used by extensions) does now properly respect
the current doctype and therefore omits the ending
slash at the end for HTML5.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1013

  1. Oli Bartsch uploaded patch set 1 05/23/24, 16:11

  2. core-ci voted on patch set 1 V -1 05/23/24, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58107

  3. Oli Bartsch uploaded patch set 2 V -1 05/23/24, 16:29

  4. core-ci voted on patch set 2 V -1 05/23/24, 16:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58108

  5. Oli Bartsch uploaded patch set 3 V -1 05/23/24, 17:06

  6. core-ci voted on patch set 3 V +1 05/23/24, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58109

  7. Benni Mack voted on patch set 3 CR +1 V +1 05/23/24, 21:03

  8. Nikita Hovratov voted on patch set 3 CR +1 05/23/24, 21:39

  9. Andreas Kienast commented on patch set 3 05/24/24, 06:13

    AFAICS we don't have any test now for non-HTML5 scenarios, do we?
  10. Oli Bartsch commented on patch set 3 05/24/24, 06:48

    Reply

    I‘ve added checkRenderAllPropertiesUsesCorrectEndingSlash() for this.
  11. Andreas Kienast commented on patch set 3 CR +1 V +1 05/24/24, 07:09

    Reply

    Wow, it's so tiny and hidden. Sorry for the noise 😄
  12. Oli Bartsch voted on patch set 3 CR +2 V +2 05/24/24, 08:08

  13. Oli Bartsch merged patch set 4 05/24/24, 08:09