Review main Merged

84377[BUGFIX] Catch errors if ini_set is not allowed

Georg Ringer CR +2 V +2 Normal +213 −10 updated 09/02/26, 20:35

Commit message

If the function ini_set is part of the setting
`disable_functions` the errors must be caught to
allow a running setup.

Most of the session settings of the install tool are
best practice and it keeps working without them. Two
of them are not: session.cookie_secure keeps the
session cookie off plain HTTP, session.cookie_httponly
keeps it away from JavaScript. Both are read back with
ini_get now, and an error is logged if they are not in
effect, so a silently degraded session does not go
unnoticed.

See https://www.php.net/manual/en/ini.core.php#ini.disable-functions

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2028

Show 3 earlier messages
  1. Georg Ringer uploaded patch set 1 05/23/24, 19:44

  2. Georg Ringer commented on patch set 1 05/23/24, 19:44

    This change is ready for review.
  3. Georg Ringer uploaded patch set 2 05/23/24, 19:45

  1. core-ci voted on patch set 1 V +1 05/23/24, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58111

  2. core-ci voted on patch set 2 V +1 05/23/24, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58112

  3. Georg Ringer rebased onto patch set 3 V +1 06/26/24, 04:11

  4. core-ci voted on patch set 3 V +1 06/26/24, 04:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60344

  5. Garvin Hicking commented on patch set 3 CR -1 08/03/24, 22:57

    SessionService.php:91

    This one is rather vital (had no silencing before) so I wonder if we should still fail here, and not catch an error. If we do this, we should probably at least log an error...?
  6. Benni Mack updated the commit message in patch set 4 CR -1 V +1 10/18/24, 13:41

  7. Benni Mack rebased onto patch set 5 04/11/25, 21:11

  8. core-ci voted on patch set 5 V +1 04/11/25, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77583

  9. Benni Mack uploaded patch set 6 V +1 04/12/25, 10:24

  10. Benni Mack commented on patch set 5 04/12/25, 10:24

    SessionService.php:91 Reply

    just tested this... the sessions are rather best practice (IMHO), and it continues to work - I think this is really OK.
  11. Benni Mack voted on patch set 6 CR +1 V +1 04/12/25, 10:25

  12. core-ci voted on patch set 6 V +1 04/12/25, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77614

  13. Garvin Hicking commented on patch set 6 04/12/25, 12:00

    SessionService.php:91 Reply

    I wonder if we should do an extra tour here, see if ini_get() is possible, and compare the most vital things: - session.cookie_secure IMO MUST be set to ON for SSL env - session.cookie_httponly must be ON The rest is maybe "whatever ¯\_(ツ)_/¯ ". If those two values don't match up we could still silence this, but log an error like "Vital session settings (cookie_secure / cookie_httonly) are not properly set. TYPO3 security is impacted." (We might want to ask the Security team though for confirming?)
  14. Garvin Hicking commented on patch set 6 04/08/26, 20:05

    SessionService.php:91 Reply

    bump?
  15. Benni Mack wrote 04/21/26, 15:02

    Removed reviewer Benni Mack with the following votes: * Verified+1 by Benni Mack * Code-Review+1 by Benni Mack
  16. Benni Mack updated the commit message in patch set 7 V +1 04/22/26, 06:54

  17. core-ci voted on patch set 7 V -1 04/22/26, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100826

  18. Georg Ringer uploaded patch set 8 V -1 09/01/26, 21:03

  19. core-ci voted on patch set 8 V -1 09/01/26, 21:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107530

  20. Garvin Hicking uploaded patch set 9 V -1 09/02/26, 09:19

  21. core-ci voted on patch set 9 V +1 09/02/26, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107588

  22. Garvin Hicking commented on patch set 9 CR +1 V +1 09/02/26, 09:32

    SessionService.php:91 Reply

    Done
  23. Benni Mack voted on patch set 9 CR +1 V +1 09/02/26, 17:28

  24. Benni Mack voted on patch set 9 CR +2 V +2 09/02/26, 20:35

  25. Benni Mack merged patch set 10 09/02/26, 20:35