Review main Merged

84380[TASK] Improve usability of user/group select in log module

Georg Ringer CR +2 V +2 Easy +20 −17 updated 05/24/24, 13:25

Commit message

Instead of prefixing the type (user, group) for every option an optgroup
is used. With this change it is possible to use the keyboard to jump to
a specific letter.

Furthermore BackendUtility::getRecordTitle is used to retrieve the label
instead of using a hardcoded field name.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Georg Ringer uploaded patch set 1 05/24/24, 08:53

  2. Georg Ringer commented on patch set 1 05/24/24, 08:54

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 05/24/24, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58142

  4. Markus Klein voted on patch set 1 CR +1 05/24/24, 09:21

  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 05/24/24, 09:37

  6. Andreas Kienast voted on patch set 1 CR +1 V +1 05/24/24, 09:45

  7. Garvin Hicking voted on patch set 1 CR +1 V +1 05/24/24, 12:42

  8. Andreas Kienast voted on patch set 1 CR +2 V +2 05/24/24, 13:10

  9. Andreas Kienast merged patch set 2 05/24/24, 13:25