84383[BUGFIX] Improve and clean up Composer asset publishing
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Helmut Hummel +2
- Garvin Hicking +1
- Markus Klein +1
-
Verified V +2 Done
- Georg Ringer +2
- Helmut Hummel +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2841
Show 1116 earlier messages
-
Garvin Hicking uploaded patch set 1 05/24/24, 11:40
-
core-ci voted on patch set 1 V +1 05/24/24, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58153
-
Andreas Kienast commented on patch set 1 05/24/24, 12:08
PackageArtifactBuilder.php:322Can be simplified to `return realpath($target) === realpath($link)`; -
Garvin Hicking uploaded patch set 2
V +105/24/24, 12:15Fix return cognitive complexity -
Garvin Hicking commented on patch set 2 05/24/24, 12:15
PackageArtifactBuilder.php:297ReplyDonePackageArtifactBuilder.php:322ReplyDone -
Andreas Kienast commented on patch set 2 05/24/24, 12:17
PackageArtifactBuilder.php:308This return is superfluous. -
core-ci voted on patch set 2 V +1 05/24/24, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58157
-
Garvin Hicking uploaded patch set 3
V +105/24/24, 12:20Another return bites the dust -
Garvin Hicking commented on patch set 3 05/24/24, 12:20
PackageArtifactBuilder.php:308ReplyDone -
core-ci voted on patch set 3 V +1 05/24/24, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58158
-
Helmut Hummel commented on patch set 3 CR -1 06/03/24, 08:40
PackageArtifactBuilder.php:221the info here is obsolete imho. in any case please output all gathered warnings herePackageArtifactBuilder.php:271instead of tracking a bool, I suggest tracking the messages and output the messages in one placePackageArtifactBuilder.php:289try catch instead of if, see belowPackageArtifactBuilder.php:297the method name does not reflect what the method does when returning bool. Please change to throw an exception instead. I suggest to create a new exception class for that.PackageArtifactBuilder.php:312same here -
Garvin Hicking uploaded patch set 4
CR -1V +106/04/24, 08:23Use exceptions address code review -
Garvin Hicking commented on patch set 4 06/04/24, 08:25
@typo3@helhum.io Thanks for your suggestions, I learned something here :-) Refactored this now to utilize exceptions (two of them - one for a symlink/junction failure, and one for the "publish resources" failure as such). The iteration is done on a new private property of the PackageArtifactBuilder; I think adding this as a property to the exception event is a bit of a hassle (with parent constructor calls), and IMO the output should possibly be created by evaluation of that property and note purely Exception "storage". What do you think?PackageArtifactBuilder.php:221ReplyDonePackageArtifactBuilder.php:271ReplyDonePackageArtifactBuilder.php:289ReplyDonePackageArtifactBuilder.php:297ReplyDonePackageArtifactBuilder.php:312ReplyDone -
core-ci voted on patch set 4 V -1 06/04/24, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58668
-
Garvin Hicking uploaded patch set 5
V -106/04/24, 09:50Fix duplicate exception code -
core-ci voted on patch set 5 V -1 06/04/24, 09:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58671
-
Garvin Hicking uploaded patch set 6
V -106/04/24, 10:18Once more with exceptional feeling -
core-ci voted on patch set 6 V +1 06/04/24, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58675
-
Helmut Hummel uploaded patch set 7
V +106/04/24, 21:45 -
core-ci voted on patch set 7 V -1 06/04/24, 21:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58701
-
Garvin Hicking uploaded patch set 8
V -106/05/24, 07:27CGL minor rewording commit message update -
core-ci voted on patch set 8 V +1 06/05/24, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58723
-
Garvin Hicking uploaded patch set 9
V +106/05/24, 07:41Properly emit multiple warnings -
core-ci voted on patch set 9 V -1 06/05/24, 07:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58726
-
Garvin Hicking uploaded patch set 10
V -106/05/24, 07:55CGL continued -
core-ci voted on patch set 10 V -1 06/05/24, 07:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58729
-
Garvin Hicking uploaded patch set 11
V -106/05/24, 09:43DocBlock annotation fingers crossed -
core-ci voted on patch set 11 V +1 06/05/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58734
-
Garvin Hicking commented on patch set 11 CR +1 V +1 06/05/24, 10:58
Thanks a lot @typo3@helhum.io your rework makes sense to me (voting on "your implementation" ;). Tested this on my installation where I setup a few wrong directories and with missing write permissions. Couldn't test Windows Junctions though, but I believe that is left unchanged. -
Helmut Hummel commented on patch set 11 CR -1 06/15/24, 12:46
Working on it right now -
Helmut Hummel commented on patch set 11 V -1 06/15/24, 12:56
Symlinking is broken with this change. Will fix it -
Helmut Hummel uploaded patch set 12
CR +1V +106/15/24, 15:56 -
core-ci voted on patch set 12 V +1 06/15/24, 16:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59646
-
Helmut Hummel voted on patch set 12 CR +1 V +1 06/15/24, 16:05
-
Helmut Hummel uploaded patch set 13
CR +1V +106/15/24, 20:55 -
core-ci voted on patch set 13 V +1 06/15/24, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59656
-
Markus Klein voted on patch set 13 CR +1 06/15/24, 21:10
-
Garvin Hicking commented on patch set 13 CR +1 V +1 06/17/24, 12:48
Since Helmut did a larger rewrite on this (much appreciated) I'm voting on the implementation. I've tested it and it seems to be more maintainable then the old solution, plus addresses the issue of the ticket. Thanks! -
Helmut Hummel voted on patch set 13 CR +2 V +2 06/19/24, 14:34
-
Georg Ringer voted on patch set 13 CR +2 V +2 06/20/24, 20:07
-
Georg Ringer merged patch set 14 06/20/24, 20:07
PackageArtifactBuilder.php:297