Review main Merged

84384[BUGFIX] Ensure a correct default storage is used by default

Georg Ringer CR +2 V +2 Easy +7 −1 updated 07/31/24, 12:11

Commit message

An editor might not have access to the 1st storage defined (usually
fileadmin). To avoid an exception, an additional check compares the
default storage to the available ones.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jasmina Ließmann +1
    • Josef Glatz +1
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Georg Ringer uploaded patch set 1 05/24/24, 12:40

  2. Georg Ringer commented on patch set 1 05/24/24, 12:40

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 05/24/24, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58160

  4. core-ci voted on patch set 1 V +1 05/24/24, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58160

  5. Garvin Hicking commented on patch set 1 CR +1 V +1 06/13/24, 11:59

    If I reproduced this correctly, it seems to work 😜
  6. Georg Ringer rebased onto patch set 2 CR +1 V +1 06/19/24, 11:11

  7. core-ci voted on patch set 2 V +1 06/19/24, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59846

  8. Jasmina Ließmann voted on patch set 2 V +1 06/19/24, 12:29

  9. Christian Kuhn voted on patch set 2 CR +1 06/19/24, 12:38

  10. Garvin Hicking voted on patch set 2 CR +1 V +1 06/19/24, 13:27

  11. Josef Glatz voted on patch set 2 CR +1 V +1 07/31/24, 10:05

  12. Josef Glatz commented on patch set 2 07/31/24, 10:11

    Successfully tested in 12.4. Fixes the described problem in a productive system.
  13. Christian Kuhn voted on patch set 2 V +1 07/31/24, 11:05

  14. Georg Ringer voted on patch set 2 CR +2 V +2 07/31/24, 12:11

  15. Georg Ringer merged patch set 3 07/31/24, 12:11