Review main Merged

84385[TASK] Split an unhappy unit test

Anja Leichsenring CR +2 V +2 Normal +55 −54 updated 05/25/24, 10:07

Commit message

The test setup used a dataProvider and in order to get it's own
setup right, it reverses and resets leftover instances from the
previous run. It is way easier to split the test setup according
the admin flag, that decides about the resets, and run on a
clear dedicated environment.

Additionally, the system under test is in itself a mocked instance,
which is neither necessary in this case, nor generally recommended.
The mock has been resolved.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Anja Leichsenring uploaded patch set 1 05/24/24, 13:04

  2. core-ci voted on patch set 1 V +1 05/24/24, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58161

  3. Christian Kuhn commented on patch set 1 05/24/24, 13:11

    BackendUserAuthenticationTest.php:463

    we could just remove these comments by using named arguments for the db's single fields along the way.
  4. Anja Leichsenring uploaded patch set 2 V +1 05/24/24, 13:19

  5. Anja Leichsenring commented on patch set 2 05/24/24, 13:19

    BackendUserAuthenticationTest.php:463 Reply

    Done
  6. Oliver Klee voted on patch set 2 CR +1 V +1 05/24/24, 13:22

  7. core-ci voted on patch set 2 V +1 05/24/24, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58163

  8. Christian Kuhn voted on patch set 2 CR +1 V +1 05/24/24, 13:43

  9. Stefan Bürk voted on patch set 2 CR +1 V +1 05/25/24, 09:35

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 05/25/24, 10:07

  11. Christian Kuhn merged patch set 3 05/25/24, 10:07