84387[TASK] Optimize PageContentFetchingProcessor
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1012
-
Benni Mack uploaded patch set 1 05/24/24, 22:26
-
core-ci voted on patch set 1 V +1 05/24/24, 22:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58172
-
Christian Kuhn voted on patch set 1 CR +1 V +1 05/27/24, 12:54
-
Benjamin Franzke commented on patch set 1 CR -1 05/27/24, 13:12
PageContentFetchingProcessor.php:82how do we ensure this never leads to an sql injection? We should probably explicitly use `array(intval(...), …)` udring the composition of this query (not in a preparatory loop, that's to easy to remove during a refactoring, which'd introduce a sql injection possibility).PageContentFetchingProcessor.php:85This variable is defined from the previous foreach loop above. As we are not using slide mode here, this shouldn't be used at all, but some constant i guess, or only `null`. -
Benjamin Franzke commented on patch set 1 05/27/24, 13:24
PageContentFetchingProcessor.php:82This will create invalid SQL if the content area list witrhout slidemode is empty. -
Benjamin Franzke uploaded patch set 2
CR +1V +105/27/24, 13:31 -
Benjamin Franzke commented on patch set 2 05/27/24, 13:31
PageContentFetchingProcessor.php:75ReplyDonePageContentFetchingProcessor.php:82ReplyDonePageContentFetchingProcessor.php:82ReplyDonePageContentFetchingProcessor.php:85ReplyDone -
core-ci voted on patch set 2 V +1 05/27/24, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58349
-
Stefan Bürk voted on patch set 2 CR +1 05/27/24, 14:07
-
Stefan Bürk voted on patch set 2 V +1 05/27/24, 15:52
-
Benni Mack voted on patch set 2 CR +2 V +2 06/01/24, 21:38
-
Benni Mack merged patch set 3 06/01/24, 21:38
PageContentFetchingProcessor.php:75