Review main Merged

84388[BUGFIX] Resolve display name for shortcuts

Georg Ringer CR +2 V +2 Easy +2 −2 updated 05/25/24, 12:51

Commit message

The shortcut button requires the resolved name as display name and not
the LLL path.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Georg Ringer uploaded patch set 1 05/25/24, 08:13

  2. Georg Ringer commented on patch set 1 05/25/24, 08:14

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 05/25/24, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58193

  4. Torben Hansen uploaded patch set 2 V +1 05/25/24, 09:25

  5. Torben Hansen commented on patch set 2 CR +1 V +1 05/25/24, 09:28

    The change fixes the problem with the missing/wrong LLL: resolving. There is however another problem, when the 2 modules are bookmarked, since the bookmarked label also must include the page name and uid. This is however not part of this bugfix and I will create another issue for that
  6. core-ci voted on patch set 2 V +1 05/25/24, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58200

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 05/25/24, 12:51

  8. Christian Kuhn merged patch set 3 05/25/24, 12:51