Review main Merged

84389[TASK] Avoid invalid @deprecated annotation in QB

Christian Kuhn CR +2 V +2 Easy +1 −7 updated 05/25/24, 10:00

Commit message

The @deprecated QueryBuilder->setParameter() annotation for
$type does not reflect current signature. Remove it and clean
up the other annotations, too.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 58

  1. Christian Kuhn uploaded patch set 1 05/25/24, 08:24

  2. Christian Kuhn updated the commit message in patch set 2 05/25/24, 08:25

  3. core-ci voted on patch set 1 V +1 05/25/24, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58194

  4. core-ci voted on patch set 2 V -1 05/25/24, 08:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58195

  5. core-ci voted on patch set 2 V +1 05/25/24, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58195

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 05/25/24, 09:12

  7. Anja Leichsenring voted on patch set 2 CR +2 V +2 05/25/24, 10:00

  8. Anja Leichsenring merged patch set 3 05/25/24, 10:00