Review main Merged

84390[BUGFIX] Use parent's module icon as fallback for shortcuts

Georg Ringer CR +2 V +2 Easy +3 −0 updated 05/29/24, 08:00

Commit message

If no icon is provided for submodule, use a fallback to the icon of the
parent module instead of directly using the empty-empty icon.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Riccardo De Contardi +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Georg Ringer uploaded patch set 1 05/25/24, 08:27

  2. Georg Ringer commented on patch set 1 05/25/24, 08:27

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 05/25/24, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58196

  4. Riccardo De Contardi commented on patch set 1 V +1 05/26/24, 20:47

    Verified on 13.2.0-dev
  5. Georg Ringer commented on patch set 1 05/27/24, 17:28

    b
  6. Garvin Hicking commented on patch set 1 CR +1 V +1 05/29/24, 06:46

    Works for me! :)
  7. Georg Ringer voted on patch set 1 CR +2 V +2 05/29/24, 08:00

  8. Georg Ringer merged patch set 2 05/29/24, 08:00