Review 11.5 Merged

84393[TASK] Split an unhappy unit test

Christian Kuhn CR +2 V +2 Normal +57 −61 updated 05/25/24, 10:08

Commit message

The test setup used a dataProvider and in order to get it's own
setup right, it reverses and resets leftover instances from the
previous run. It is way easier to split the test setup according
the admin flag, that decides about the resets, and run on a
clear dedicated environment.

Additionally, the system under test is in itself a mocked instance,
which is neither necessary in this case, nor generally recommended.
The mock has been resolved.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 05/25/24, 09:57

  2. core-ci voted on patch set 1 V +1 05/25/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58202

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 05/25/24, 10:08

  4. Christian Kuhn merged patch set 2 05/25/24, 10:08