Review main Merged

84396[TASK] Do not suppress touch() error in a test

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 05/25/24, 11:32

Commit message

releaseDoesNotRemoveFilesNotWithinTypo3TempLocksDirectory() is
a bit flaky on CI.

This seems to happen occassionally with unitRandom, but is hard
to track down, and there may be multiple reasons. One possible
reason is that touch() fails, maybe due to a different test
changing Environment, but not resetting it. Unfortunately, we
do not see a warning when touch() fails since it is suppressed
with `@`. This was introduced in #88255, then skipping the test,
and that skip operation has been removed with #102110.

To see if the touch operation is the root of all evil, we'll for
now remove the `@` again to potentially receive a php warning
with an early fail. This may make this situation reproducible
locally, to drill down the true reason of this occassional fail.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 05/25/24, 11:05

  2. Anja Leichsenring voted on patch set 1 CR +1 V +1 05/25/24, 11:09

  3. core-ci voted on patch set 1 V +1 05/25/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58209

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 05/25/24, 11:11

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 05/25/24, 11:32

  6. Christian Kuhn merged patch set 2 05/25/24, 11:32