Review main Merged

84397[TASK] Clean up DH->copyL10nOverlayRecords()

Christian Kuhn CR +2 V +2 Normal +56 −57 updated 05/25/24, 11:56

Commit message

* Set this internal method to protected
* Add type hints for two arguments that are safe to set
* Skip BU::isTableLocalizable(), and check state of the
  two main TCA 'ctrl' props with an early return instead
* add @todo for incomplete use of getTSconfig_pidValue() results
* $this->BE_USER->workspace is always an int, skip cast
* fetchAllAssociative() always returns an array, remove
  an if and return early with empty result set instead

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 05/25/24, 11:31

  2. core-ci voted on patch set 1 V +1 05/25/24, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58212

  3. Christian Kuhn uploaded patch set 2 V +1 05/25/24, 11:42

  4. core-ci voted on patch set 2 V +1 05/25/24, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58213

  5. Anja Leichsenring voted on patch set 2 CR +1 V +1 05/25/24, 11:46

  6. Stefan Bürk voted on patch set 2 CR +2 V +2 05/25/24, 11:49

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 05/25/24, 11:49

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 05/25/24, 11:56

  9. Christian Kuhn merged patch set 3 05/25/24, 11:56